From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Subject: Re: [PATCH 1/2] test-lib: allow test snippets as here-docs
Date: Fri, 9 Apr 2021 18:30:30 -0400 [thread overview]
Message-ID: <YHDVhmveVlkHPBNb@coredump.intra.peff.net> (raw)
In-Reply-To: <YHDVAxxKDzfTlq3h@coredump.intra.peff.net>
On Fri, Apr 09, 2021 at 06:28:19PM -0400, Jeff King wrote:
> + If <script> is `-` (a single dash), then the script to run is read
> + from stdin. This lets you more easily use single quotes within the
> + script by using a here-doc. For example:
> +
> + test_expect_success 'output contains expected string' <<-\EOT
> + grep "this string has 'quotes' in it" output
> + EOT
Whoops, this should have an extra "-", of course (I got this wrong in
the cover letter, too). I.e.:
test_expect_success 'whatever' - <<\EOT
...
EOT
It would be nice to drop it, but then:
test_expect_success PREREQ 'whatever' <<\EOT
becomes ambiguous (and I don't think there is a portable and reliable
way to decide that our input is coming from a here-doc versus the
original stdin).
-Peff
next prev parent reply other threads:[~2021-04-09 22:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 22:26 [RFC/PATCH 0/2] here-doc test bodies Jeff King
2021-04-09 22:28 ` [PATCH 1/2] test-lib: allow test snippets as here-docs Jeff King
2021-04-09 22:30 ` Jeff King [this message]
2021-04-09 22:56 ` Junio C Hamano
2021-04-10 0:57 ` Junio C Hamano
2021-04-10 1:26 ` Jeff King
2021-04-10 8:30 ` Ævar Arnfjörð Bjarmason
2021-04-09 22:28 ` [PATCH 2/2] t1404: convert to here-doc test bodies Jeff King
2021-04-10 1:03 ` [RFC/PATCH 0/2] " Derrick Stolee
2021-04-10 1:34 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHDVhmveVlkHPBNb@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).