From: Jeff King <peff@peff.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>,
Patrick Steinhardt <ps@pks.im>,
git@vger.kernel.org
Subject: Re: What's cooking in git.git (Apr 2021, #04; Thu, 15)
Date: Sat, 17 Apr 2021 04:47:09 -0400 [thread overview]
Message-ID: <YHqgjR0YDDgergpS@coredump.intra.peff.net> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2104161320250.52@tvgsbejvaqbjf.bet>
On Fri, Apr 16, 2021 at 01:21:01PM +0200, Johannes Schindelin wrote:
> > Looks like this fails CI on the Windows VS build. I get:
> >
> > ++ env GIT_CONFIG_GLOBAL=does-not-exist GIT_CONFIG_SYSTEM=/dev/null git config --global --list
> > fatal: unable to access 'nul': Invalid argument
> >
> > from t1300.181. I thought we had some magic to make /dev/null work there
> > (or maybe this _is_ the magic kicking in, since it is looking for the
> > Windows-ish nul, but it is not working for some reason).
>
> Seems that this fixes it for me:
> [...]
> Subject: [PATCH] msvc: avoid calling `access("NUL", flags)`
Doh, I should have realized it was about access() from the message.
Thank you for a quick fix!
I do wonder if we should (not now, but in the longer term) ditch these
access() calls in git-config entirely (and just rely on errno we see
after calling fopen). The current code is a TOCTOU race (though one that
is unlikely to matter much in practice).
-Peff
next prev parent reply other threads:[~2021-04-17 8:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 0:04 What's cooking in git.git (Apr 2021, #04; Thu, 15) Junio C Hamano
2021-04-16 2:59 ` Jeff King
2021-04-16 3:04 ` Jeff King
2021-04-16 11:21 ` Johannes Schindelin
2021-04-16 13:33 ` Junio C Hamano
2021-04-17 8:47 ` Jeff King [this message]
2021-04-17 13:19 ` Ævar Arnfjörð Bjarmason
2021-04-18 16:55 ` Sergey Organov
2021-04-18 19:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHqgjR0YDDgergpS@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).