From: Jeff King <peff@peff.net>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org,
"brian m. carlson" <sandals@crustytoothpaste.net>,
Eric Wong <e@80x24.org>
Subject: Re: What's cooking in git.git (Apr 2021, #05; Mon, 19)
Date: Fri, 23 Apr 2021 10:41:12 -0400 [thread overview]
Message-ID: <YILciIL/WtNWdOPF@coredump.intra.peff.net> (raw)
In-Reply-To: <87mttt2hcu.fsf@evledraar.gmail.com>
On Tue, Apr 20, 2021 at 03:52:33PM +0200, Ævar Arnfjörð Bjarmason wrote:
> > * ab/fsck-unexpected-type (2021-04-13) 6 commits
> > - fsck: report invalid object type-path combinations
> > - fsck: report invalid types recorded in objects
> > - object-store.h: move read_loose_object() below 'struct object_info'
> > - fsck: don't hard die on invalid object types
> > - fsck tests: refactor one test to use a sub-repo
> > - cache.h: move object functions to object-store.h
> >
> > "git fsck" has been taught to report mismatch between expected and
> > actual types of an object better.
>
> Jeff King: *re-poke* per the mention the last WC: I.e. did you review
> this?
I hadn't, but I just did. I had some organizational nits to pick in the
middle, but there's something really wrong with the cat-file changes in
patch 5. I stopped there for now, because at least one of us is really
confused. ;)
-Peff
next prev parent reply other threads:[~2021-04-23 14:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 23:25 What's cooking in git.git (Apr 2021, #05; Mon, 19) Junio C Hamano
2021-04-20 13:23 ` Matheus Tavares Bernardino
2021-04-20 13:52 ` Ævar Arnfjörð Bjarmason
2021-04-20 22:15 ` Junio C Hamano
2021-04-20 23:14 ` brian m. carlson
2021-04-21 8:26 ` Ævar Arnfjörð Bjarmason
2021-04-21 22:32 ` brian m. carlson
2021-04-20 23:51 ` Junio C Hamano
2021-04-23 14:41 ` Jeff King [this message]
2021-04-20 14:28 ` Jeff Hostetler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YILciIL/WtNWdOPF@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).