git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: "Martin Ågren" <martin.agren@gmail.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
	"Eric Sunshine" <sunshine@sunshineco.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH] t: avoid sed-based chain-linting in some expensive cases
Date: Sat, 15 May 2021 05:19:21 -0400	[thread overview]
Message-ID: <YJ+SGfD7kPEW6ysn@coredump.intra.peff.net> (raw)
In-Reply-To: <CAN0heSrjPJG_OGyV2dt9bOfkd07He=kBUKQ-+w5JXNae+YH7qg@mail.gmail.com>

On Fri, May 14, 2021 at 10:52:35AM +0200, Martin Ågren wrote:

> > Yeah, I suspect that would work in general. But it seems like even more
> > complexity (now you have a cache of "I linted this script at time X and
> > it was good" that has to be written). It does increase the possible
> > savings though (up to perhaps 100 or so seconds of parallel CPU in my
> > case).
> 
> Yeah, I thought about the cache. I guess it would be a list of
> known-good test script hashes / blob IDs. But what I actually meant was
> to check whether the mtime was way back in the past. It's not fool-proof
> though. You could have a network-mounted disk where the date is way off,
> or you could hack up the test script, wait for several weeks and *then*
> run it. ;)

Ah, I see. You'd set some date for "this is so old you've probably run
the linting on it by now". Yeah, that is less complex to implement. It
does feel awfully magical, though.

-Peff

      reply	other threads:[~2021-05-15  9:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-13  6:25 Jeff King
2021-05-13  6:49 ` Junio C Hamano
2021-05-13  7:23   ` Jeff King
2021-05-13 11:05 ` Martin Ågren
2021-05-14  5:48   ` Jeff King
2021-05-14  8:52     ` Martin Ågren
2021-05-15  9:19       ` Jeff King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YJ+SGfD7kPEW6ysn@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=martin.agren@gmail.com \
    --cc=sunshine@sunshineco.com \
    --subject='Re: [PATCH] t: avoid sed-based chain-linting in some expensive cases' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).