git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Will Chandler <wfc@wfchandler.org>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, ps@pks.im
Subject: Re: [PATCH] refs: cleanup directories when deleting packed ref
Date: Sat, 8 May 2021 00:27:45 -0400	[thread overview]
Message-ID: <YJYTQYk5q8g6HaIm@mini.wfchandler.org> (raw)
In-Reply-To: <YJXF4xA0GFx2/2v4@coredump.intra.peff.net>

On Fri, May 07, 2021 at 06:57:39PM -0400, Jeff King wrote:
> Getting back to your patch, though, you are definitely fixing a problem
> with update-ref (which correctly realizes there is no loose ref to clean
> up, but forgets that we had to make a lockfile). And the solution you
> have looks correct. I think you just need to update the test to exercise
> it with "update-ref -d".

Thanks for the thorough analysis! Apologies for the confusion, I really
appreciate your patience.

I'll get the test fixed and note that this is specific to 'update-ref'.

  reply	other threads:[~2021-05-08  4:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-07 14:37 Will Chandler
2021-05-07 21:56 ` Jeff King
2021-05-07 22:02   ` Jeff King
2021-05-07 22:57     ` Jeff King
2021-05-08  4:27       ` Will Chandler [this message]
2021-05-08  5:00         ` Will Chandler
2021-05-08  5:21           ` Bagas Sanjaya
2021-05-08  6:24             ` Junio C Hamano
2021-05-09 18:45               ` Will Chandler
2021-05-10  1:15                 ` Junio C Hamano
2021-05-11  1:35           ` Jeff King
2021-05-11  4:58             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YJYTQYk5q8g6HaIm@mini.wfchandler.org \
    --to=wfc@wfchandler.org \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    --subject='Re: [PATCH] refs: cleanup directories when deleting packed ref' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).