From: Jeff King <firstname.lastname@example.org> To: Jeff Hostetler <email@example.com> Cc: Taylor Blau <firstname.lastname@example.org>, Bagas Sanjaya <email@example.com>, Git Users <firstname.lastname@example.org>, "brian m . carlson" <email@example.com> Subject: Re: "bad revision" fetch error when fetching missing objects from partial clones Date: Thu, 13 May 2021 05:57:57 -0400 [thread overview] Message-ID: <YJz4JTsFjTtL7mE2@coredump.intra.peff.net> (raw) In-Reply-To: <firstname.lastname@example.org> On Tue, May 11, 2021 at 02:44:52PM -0400, Jeff Hostetler wrote: > > > remote: ...<skipped> > > > Receiving objects: 100% (64/64), 154.49 KiB | 2.97 MiB/s, done. > > > remote: ...<skipped> > > > Receiving objects: 100% (37/37), 168.35 KiB | 4.95 MiB/s, done. > > > Resolving deltas: 100% (5/5), done. > > > Resolving deltas: 100% (49/49), completed with 47 local objects. > > > fatal: bad revision 'd5e9cd36ab21839af3d116eff3221c53f6ca7fd6' > > > error: https://<myhost>/bagas/gitea.git did not send all necessary > > > objects > [...] > > I'm not sure why you're getting that error, but you might > also try enabling `uploadpack.allowAnySHA1InWant` > (or one of the other "allow*SHS1InWant" values) and see if > that helps. That shouldn't be necessary these days, since the v2 protocol allows arbitrary objects to be fetched. I think it is actually a bug with pack-objects not sending the object, but it only seems to trigger with bitmaps. This works: git init repo cd repo echo content >file git add file git commit -m base git config uploadpack.allowfilter true git clone --no-local --bare --filter=blob:none . clone cd clone git fetch origin $(git rev-parse HEAD:file) But if I add a "git repack -adb" in the parent repository before the "cd clone", then I get: remote: Total 0 (delta 0), reused 0 (delta 0), pack-reused 0 fatal: bad revision 'd95f3ad14dee633a758d2e331151e950dd13e4ed' error: /home/peff/tmp/repo/. did not send all necessary objects So presumably this is a bug in the bitmap-aware filtering code that is not present in the regular filter-traversing code. But what really puzzles me is that the result seems totally broken. Yet the test coverage in t5310 passes, and nobody has noticed on major sites like GitHub (which supports partial clones and most certainly has bitmaps enabled). So I think it will require some digging. My _guess_ is that it has to do with the "never filter out an object that was explicitly requested" rule not being consistently followed. But we'll see. -Peff
next prev parent reply other threads:[~2021-05-13 9:58 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-07 12:56 Bagas Sanjaya 2021-05-11 18:44 ` Jeff Hostetler 2021-05-13 9:57 ` Jeff King [this message] 2021-05-13 10:53 ` Jeff King 2021-05-14 7:27 ` Jeff King 2021-05-17 6:03 ` Patrick Steinhardt 2021-05-17 6:31 ` Jeff King 2021-05-17 16:25 ` Derrick Stolee 2021-05-18 8:11 ` Jeff King 2021-05-18 10:14 ` Bagas Sanjaya 2021-05-18 14:04 ` Derrick Stolee 2021-05-15 6:52 ` Bagas Sanjaya
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YJz4JTsFjTtL7mE2@coredump.intra.peff.net \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: "bad revision" fetch error when fetching missing objects from partial clones' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).