git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Jeff King <peff@peff.net>
Cc: "Taylor Blau" <me@ttaylorr.com>,
	"Junio C Hamano" <gitster@pobox.com>,
	git@vger.kernel.org, "Han-Wen Nienhuys" <hanwen@google.com>,
	"Avar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"ZheNing Hu" <adlternative@gmail.com>
Subject: Re: CI: 'seen' minus a few passes tests, eh, almost
Date: Wed, 26 May 2021 12:48:39 -0400	[thread overview]
Message-ID: <YK5754JqOUXL/+/L@nand.local> (raw)
In-Reply-To: <YK5u/qxFJUr9d/qS@coredump.intra.peff.net>

On Wed, May 26, 2021 at 11:53:34AM -0400, Jeff King wrote:
> On Wed, May 26, 2021 at 10:39:53AM -0400, Taylor Blau wrote:
>
> > On Wed, May 26, 2021 at 02:32:19PM +0900, Junio C Hamano wrote:
> > > Just with a hunch, I further excluded tb/multi-pack-bitmaps from
> > > 'seen', in addition to these four topics.  It seems to pass the
> > > whole test suite on both 32- and 64-bit build combinations.
> > >
> > >     https://github.com/git/git/actions/runs/877225207
> > >
> > > Except that vs-build sometimes fails to download the sdk, that is.
> >
> > Thanks for letting me know. I have accumulated a few local changes that
> > I wanted to include in a reroll of that topic, but I was waiting on
> > other reviewer eyes before sending it.
>
> I think the best thing in a situation like this (where reviewers like me
> have been very slow to respond) is to repost it explaining the
> situation. That makes it clear what the current state is, and brings it
> to the forefront of the list's attention (both reviewers you'd expect to
> look at it, but people in general). Doing that too often can be
> obnoxious, of course, but after 6-8 weeks saying "hey, this didn't get
> attention; can anybody take a look at it?" is perfectly reasonable.

Indeed, but I had been putting even doing that off. I've had some
sporadic time off in the last few months (as you know) and so usually by
the time that I'm back enough other stuff has accumulated that I don't
feel like adding more to the list by encouraging further review.

So the topic (and my participation on the list in general) has kind of
languished, but I'm hoping that since things have mostly cooled down for
me outside of work that I'll be able to participate and submit patches
more consistently.

Thanks,
Taylor

  reply	other threads:[~2021-05-26 16:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-25 22:25 CI: 'seen' minus a few passes tests, eh, almost Junio C Hamano
2021-05-26  5:32 ` Junio C Hamano
2021-05-26  6:07   ` Junio C Hamano
2021-05-26 14:39   ` Taylor Blau
2021-05-26 15:53     ` Jeff King
2021-05-26 16:48       ` Taylor Blau [this message]
2021-06-02 11:59   ` Johannes Schindelin
2021-05-26 15:02 ` ZheNing Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YK5754JqOUXL/+/L@nand.local \
    --to=me@ttaylorr.com \
    --cc=adlternative@gmail.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=hanwen@google.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).