From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C620C433ED for ; Mon, 17 May 2021 08:57:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2CA9760FF3 for ; Mon, 17 May 2021 08:57:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235794AbhEQI7H (ORCPT ); Mon, 17 May 2021 04:59:07 -0400 Received: from cloud.peff.net ([104.130.231.41]:56110 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232924AbhEQI7G (ORCPT ); Mon, 17 May 2021 04:59:06 -0400 Received: (qmail 4623 invoked by uid 109); 17 May 2021 08:57:50 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Mon, 17 May 2021 08:57:50 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 26647 invoked by uid 111); 17 May 2021 08:57:50 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Mon, 17 May 2021 04:57:50 -0400 Authentication-Results: peff.net; auth=none Date: Mon, 17 May 2021 04:57:49 -0400 From: Jeff King To: Felipe Contreras Cc: git@vger.kernel.org, Martin =?utf-8?B?w4VncmVu?= , "brian m . carlson" , =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Subject: Re: [PATCH 01/11] doc: allow the user to provide ASCIIDOC_EXTRA Message-ID: References: <20210514121435.504423-1-felipe.contreras@gmail.com> <20210514121435.504423-2-felipe.contreras@gmail.com> <609fbafc73fcd_e173a208f4@natae.notmuch> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <609fbafc73fcd_e173a208f4@natae.notmuch> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Sat, May 15, 2021 at 07:13:48AM -0500, Felipe Contreras wrote: > Jeff King wrote: > > On Sat, May 15, 2021 at 05:32:08AM -0400, Jeff King wrote: > > > > > On Fri, May 14, 2021 at 07:14:25AM -0500, Felipe Contreras wrote: > > > > > > > Without `override` all additions will be ignored by make. > > > > > > That's true of all of our Makefile variables. Is there a particular > > > reason to give this one special treatment? > > > > To go into further detail: usually we distinguish variables we use > > internally from user-facing ones, and include the latter in the former. > > I see a later patch wants to start passing ASCIIDOC_EXTRA on the > > command-line, and we'd use two variables for that. > > Well, it's not exactly user-facing; it's only needed for doc-diff. It's meant for the caller of "make". Your proposed use is within doc-diff, but any user running "make ASCIIDOC_EXTRA=foo" would see the different behavior. > Would TEST_ASCIIDOC_EXTRA make sense? I'd probably call it ASCIIDOC_FLAGS (like we have CFLAGS and LDFLAGS that are meant for users to inform us of extra flags they'd like passed). Of course that may not solve your problem in a sense; if you want doc-diff to override it, then that might conflict with a theoretical ASCIIDOC_FLAGS somebody set in their config.mak (but we really are in the realm of hypothetical here). -Peff