From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8A97C4708F for ; Tue, 1 Jun 2021 15:55:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BFFCF61396 for ; Tue, 1 Jun 2021 15:55:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234256AbhFAP5B (ORCPT ); Tue, 1 Jun 2021 11:57:01 -0400 Received: from cloud.peff.net ([104.130.231.41]:43314 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230523AbhFAP5A (ORCPT ); Tue, 1 Jun 2021 11:57:00 -0400 Received: (qmail 28422 invoked by uid 109); 1 Jun 2021 15:55:18 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Tue, 01 Jun 2021 15:55:18 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 11692 invoked by uid 111); 1 Jun 2021 15:55:18 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 01 Jun 2021 11:55:18 -0400 Authentication-Results: peff.net; auth=none Date: Tue, 1 Jun 2021 11:55:17 -0400 From: Jeff King To: ZheNing Hu via GitGitGadget Cc: git@vger.kernel.org, Junio C Hamano , Christian Couder , Hariom Verma , Felipe Contreras , ZheNing Hu Subject: Re: [PATCH 2/2] [GSOC] cat-file: merge two block into one Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Jun 01, 2021 at 02:35:57PM +0000, ZheNing Hu via GitGitGadget wrote: > From: ZheNing Hu > > Because the two "if (opt->all_objects)" block > are redundant, merge them into one, to provide > better readability. Funny indentation of the commit message. :) I think this is worth doing, and I agree the end-result is easier to read. Really minor nit, but I probably wouldn't have said "redundant" here. The conditionals themselves are redundant, but not the blocks. Maybe: There are two "if (opt->all_objects)" blocks next to each other; merge them into one to provide better readability. (not a huge deal, as I think seeing the patch helps explain what is going on. But again, just trying to offer polishing advice for future patches)