From: Jeff King <peff@peff.net>
To: ZheNing Hu <adlternative@gmail.com>
Cc: ZheNing Hu via GitGitGadget <gitgitgadget@gmail.com>,
Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Christian Couder <christian.couder@gmail.com>,
Hariom Verma <hariom18599@gmail.com>,
Felipe Contreras <felipe.contreras@gmail.com>
Subject: Re: [PATCH 1/2] [GSOC] cat-file: fix --batch report changed-type bug
Date: Thu, 3 Jun 2021 15:28:43 -0400 [thread overview]
Message-ID: <YLktazqb0yY5LK/V@coredump.intra.peff.net> (raw)
In-Reply-To: <CAOLTT8QMpMV=7A4ZP2k5YUrqjznBwh_uDv+qvC7Meq3pwvZt1g@mail.gmail.com>
On Thu, Jun 03, 2021 at 03:18:43PM +0800, ZheNing Hu wrote:
> Jeff King <peff@peff.net> 于2021年6月3日周四 上午4:01写道：
> >
> > This assumption was broken by 845de33a5b (cat-file: avoid noop calls
> > to sha1_object_info_extended, 2016-05-18). That commit skips the call
> > to oid_object_info_extended() entirely when --batch-all-objects is in
> > use, and the custom format does not include any placeholders that
> > require calling it.
> >
>
> Or when the custom format only include placeholders like %(objectname) or
> %(rest), oid_object_info_extended() will not get the type of the object.
Yeah, that's what I was trying to get at with "placeholders that require
calling it", but I couldn't think of a less awkward way to say that. :)
Spelling it out is probably a good idea.
-Peff
next prev parent reply other threads:[~2021-06-03 19:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 14:35 [PATCH 0/2] [GSOC] cat-file: fix --batch report changed-type bug ZheNing Hu via GitGitGadget
2021-06-01 14:35 ` [PATCH 1/2] " ZheNing Hu via GitGitGadget
2021-06-01 15:52 ` Jeff King
2021-06-02 13:15 ` ZheNing Hu
2021-06-02 20:00 ` Jeff King
2021-06-03 6:28 ` ZheNing Hu
2021-06-03 7:18 ` ZheNing Hu
2021-06-03 19:28 ` Jeff King [this message]
2021-06-01 14:35 ` [PATCH 2/2] [GSOC] cat-file: merge two block into one ZheNing Hu via GitGitGadget
2021-06-01 15:55 ` Jeff King
2021-06-02 13:27 ` ZheNing Hu
2021-06-03 16:29 ` [PATCH v2 0/2] [GSOC] cat-file: fix --batch report changed-type bug ZheNing Hu via GitGitGadget
2021-06-03 16:29 ` [PATCH v2 1/2] [GSOC] cat-file: handle trivial --batch format with --batch-all-objects ZheNing Hu via GitGitGadget
2021-06-03 16:29 ` [PATCH v2 2/2] [GSOC] cat-file: merge two block into one ZheNing Hu via GitGitGadget
2021-06-03 19:29 ` [PATCH v2 0/2] [GSOC] cat-file: fix --batch report changed-type bug Jeff King
2021-06-03 22:51 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLktazqb0yY5LK/V@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=adlternative@gmail.com \
--cc=christian.couder@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=hariom18599@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).