From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 384C9C636C8 for ; Tue, 20 Jul 2021 21:11:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 235DA60C41 for ; Tue, 20 Jul 2021 21:11:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236024AbhGTUaZ (ORCPT ); Tue, 20 Jul 2021 16:30:25 -0400 Received: from cloud.peff.net ([104.130.231.41]:55406 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229738AbhGTUVs (ORCPT ); Tue, 20 Jul 2021 16:21:48 -0400 Received: (qmail 5115 invoked by uid 109); 20 Jul 2021 21:02:25 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Tue, 20 Jul 2021 21:02:25 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 27474 invoked by uid 111); 20 Jul 2021 21:02:25 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 20 Jul 2021 17:02:25 -0400 Authentication-Results: peff.net; auth=none Date: Tue, 20 Jul 2021 17:02:24 -0400 From: Jeff King To: Taylor Blau Cc: git@vger.kernel.org, jonathantanmy@google.com Subject: Re: [PATCH] pack-bitmap: clarify comment in filter_bitmap_exclude_type() Message-ID: References: <0d52628985bf4f499e0d5622ea40cdf499e73ebe.1626812121.git.me@ttaylorr.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <0d52628985bf4f499e0d5622ea40cdf499e73ebe.1626812121.git.me@ttaylorr.com> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Jul 20, 2021 at 04:16:22PM -0400, Taylor Blau wrote: > The code that eventually became filter_bitmap_exclude_type() was > originally introduced in 4f3bd5606a (pack-bitmap: implement BLOB_NONE > filtering, 2020-02-14) to accelerate BLOB_NONE filters with bitmaps. > > In 856e12c18a (pack-bitmap.c: make object filtering functions generic, > 2020-05-04), it became filter_bitmap_exclude_type(). But not all of the > comments were updated to be agnostic to the provided type. > > Remove the remaining comments which should have been updated in > 856e12c18a to reflect the type-agnostic nature of the function. > > Signed-off-by: Taylor Blau > --- > Noticed while I was reading some code in this area to see if we had > accelerated the relatively new type filters. This trivial fix hopefully > shouldn't produce conflicts with other in-flight bitmap series. Yep, this looks good. I wrote a near-identical patch while working on [1], but that topic got stalled on "how is this part of partial clones even supposed to work?". But there's no reason not to make this trivial fix in isolation. -Peff