From: Jeff King <peff@peff.net>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] http: check CURLE_SSL_PINNEDPUBKEYNOTMATCH when emitting errors
Date: Fri, 24 Sep 2021 17:24:52 -0400 [thread overview]
Message-ID: <YU5CJC9XJvQITfr8@coredump.intra.peff.net> (raw)
In-Reply-To: <patch-1.1-6e65734cbce-20210924T100532Z-avarab@gmail.com>
On Fri, Sep 24, 2021 at 12:08:20PM +0200, Ævar Arnfjörð Bjarmason wrote:
> Change the error shown when a http.pinnedPubKey doesn't match to point
> the http.pinnedPubKey variable added in aeff8a61216 (http: implement
> public key pinning, 2016-02-15), e.g.:
>
> git -c http.pinnedPubKey=sha256/someNonMatchingKey ls-remote https://github.com/git/git.git
> fatal: unable to access 'https://github.com/git/git.git/' with http.pinnedPubkey configuration: SSL: public key does not match pinned public key!
TBH, I think the message as-is is sufficiently descriptive. That said,
it's not too much extra code to handle it specially, so I don't feel all
that strongly.
Maybe people care more about the translation aspect, but it feels like
that's the tip of the iceberg in terms of curl errors.
The patch itself looks correct to me.
-Peff
next prev parent reply other threads:[~2021-09-24 21:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 10:08 [PATCH] http: check CURLE_SSL_PINNEDPUBKEYNOTMATCH when emitting errors Ævar Arnfjörð Bjarmason
2021-09-24 21:24 ` Jeff King [this message]
2021-10-10 21:42 ` SZEDER Gábor
2021-10-11 1:49 ` Ævar Arnfjörð Bjarmason
2021-10-11 4:47 ` SZEDER Gábor
2021-10-11 13:23 ` Ævar Arnfjörð Bjarmason
2021-10-11 16:12 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YU5CJC9XJvQITfr8@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).