From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Taylor Blau" <me@ttaylorr.com>,
"Carlo Marcelo Arenas Belón" <carenas@gmail.com>,
git@vger.kernel.org, peff@peff.net
Subject: Re: [PATCH 2/2] t0000: avoid masking git exit value through pipes
Date: Thu, 16 Sep 2021 12:49:14 -0400 [thread overview]
Message-ID: <YUN1igX4f4hLUMvA@nand.local> (raw)
In-Reply-To: <xmqq8rzxujhb.fsf@gitster.g>
On Wed, Sep 15, 2021 at 11:23:28PM -0700, Junio C Hamano wrote:
> Taylor Blau <me@ttaylorr.com> writes:
>
> >> + tree=$(cat out | sed -n -e "s/^tree //p" -e "/^author /q") &&
> >
> > In this and the below tests which had a similar transformation, the
> > first invocation does not mask its error, since it's on the right-hand
> > side of a pipe.
> >
> > But piping "git show" to sed will mask the exit code of the former. So
> > that makes sense. But I would like to see us avoid an unnecessary
> > cat-into-pipe and instead redirect out into sed, like "sed -n -e ...
> > <out".
>
> [...] or for commands like "sed" that takes its input from files
> listed on the command line, you should be able to write it without the
> input "<" redirection.
Even better, thanks for noticing the flaw in my suggestion.
Thanks,
Taylor
next prev parent reply other threads:[~2021-09-16 18:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 2:37 [PATCH 0/2] t0000: truly leak free Carlo Marcelo Arenas Belón
2021-09-16 2:37 ` [PATCH 1/2] tree-diff: fix leak when not HAVE_ALLOCA Carlo Marcelo Arenas Belón
2021-09-16 5:17 ` Taylor Blau
2021-09-16 5:27 ` Junio C Hamano
2021-09-16 2:37 ` [PATCH 2/2] t0000: avoid masking git exit value through pipes Carlo Marcelo Arenas Belón
2021-09-16 5:21 ` Taylor Blau
2021-09-16 6:23 ` Junio C Hamano
2021-09-16 16:49 ` Taylor Blau [this message]
2021-09-16 5:29 ` Junio C Hamano
2021-09-16 10:45 ` Ævar Arnfjörð Bjarmason
2021-09-16 8:55 ` [PATCH v2 0/2] reroll for cb/plug-leaks-in-alloca-emu-users Carlo Marcelo Arenas Belón
2021-09-16 8:55 ` [PATCH v2 1/2] tree-diff: fix leak when not HAVE_ALLOCA_H Carlo Marcelo Arenas Belón
2021-09-16 15:00 ` Jeff King
2021-09-16 8:55 ` [PATCH v2 2/2] t0000: avoid masking git exit value through pipes Carlo Marcelo Arenas Belón
2021-09-16 16:53 ` [PATCH v2 0/2] reroll for cb/plug-leaks-in-alloca-emu-users Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUN1igX4f4hLUMvA@nand.local \
--to=me@ttaylorr.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).