Re: [PATCH v2 2/2] gitweb: remove invalid http-equiv="content-type"

From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Jason Yundt <jason@jasonyundt.email>
Cc: git@vger.kernel.org, "Jeff King" <peff@peff.net>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH v2 2/2] gitweb: remove invalid http-equiv="content-type"
Date: Tue, 8 Mar 2022 01:50:27 +0000	[thread overview]
Message-ID: <Yia2Y2zoOjvVdJ9O@camp.crustytoothpaste.net> (raw)
In-Reply-To: <20220308010711.61817-3-jason@jasonyundt.email>

[-- Attachment #1: Type: text/plain, Size: 814 bytes --]

On 2022-03-08 at 01:07:11, Jason Yundt wrote:
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index fbd1c20a23..59457c1004 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -4225,7 +4225,7 @@ sub git_header_html {
>  <!-- git web interface version $version, (C) 2005-2006, Kay Sievers <kay.sievers\@vrfy.org>, Christian Gierke -->
>  <!-- git core binaries version $git_version -->
>  <head>
> -<meta http-equiv="content-type" content="$content_type; charset=utf-8"/>
> +<meta charset="utf-8"/>

I don't actually think this is an improvement.  I don't think it's
necessary, considering we have an XML declaration and the HTTP header,
both of which already say it's UTF-8 and will take precedence over this.
-- 
brian m. carlson (he/him or they/them)
Toronto, Ontario, CA

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 262 bytes --]