git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: jk/unused-annotation + ab/unused-annotation (was: What's cooking in git.git (Aug 2022, #10; Tue, 30))
Date: Wed, 31 Aug 2022 11:27:00 -0400	[thread overview]
Message-ID: <Yw99xMnkiv/Qjnst@coredump.intra.peff.net> (raw)
In-Reply-To: <220831.86fshcal32.gmgdl@evledraar.gmail.com>

On Wed, Aug 31, 2022 at 10:00:50AM +0200, Ævar Arnfjörð Bjarmason wrote:

> I see you did this already in 4f464a7b54a (Revert "Merge branch
> 'jk/unused-annotation' into next", 2022-08-30), per [1] and [2] you &
> Jeff seemed to agree on my approach in [3] as a way forward.
> 
> The ab/unused-annotation in "seen" (not in this WC E-Mail) is a rebased
> version of 1/2 of that series. Without the 2/2 [4] it won't catch the
> accidental use of parameters.
> 
> Were you planning on picking that up, or would you like it submitted
> separately? I know there were reservations about (ab)using "deprecated"
> for this, but per the rationale in [4] and Jeff's [2] it seemed like
> there was consensus to go that route.

Yeah, I think we should use the deprecated attribute. Since the original
has been reverted, I think the next step would be for me to fix up the
patches to use that approach from the start, and re-submit.

I was dragging my feet a little hoping that we might get some coccinelle
parsing miracle in the interim.

-Peff

  reply	other threads:[~2022-08-31 15:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-30 19:17 What's cooking in git.git (Aug 2022, #10; Tue, 30) Junio C Hamano
2022-08-30 20:40 ` js/bisect-in-c, was " Johannes Schindelin
2022-08-31  8:00 ` jk/unused-annotation + ab/unused-annotation (was: What's cooking in git.git (Aug 2022, #10; Tue, 30)) Ævar Arnfjörð Bjarmason
2022-08-31 15:27   ` Jeff King [this message]
2022-08-31 16:23     ` jk/unused-annotation + ab/unused-annotation Junio C Hamano
2022-08-31 17:21       ` Ævar Arnfjörð Bjarmason
2022-08-31  8:29 ` js/add-p-diff-parsing-fix (was: What's cooking in git.git (Aug 2022, #10; Tue, 30)) Ævar Arnfjörð Bjarmason
2022-08-31  9:31   ` Phillip Wood
2022-08-31 19:54     ` Johannes Schindelin
2022-08-31 20:15       ` js/add-p-diff-parsing-fix Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yw99xMnkiv/Qjnst@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).