git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Cc: Patrick Steinhardt <ps@pks.im>, Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 0/2] bug with rev-list --verify-objects and commit-graph
Date: Tue, 6 Sep 2022 16:58:59 -0400	[thread overview]
Message-ID: <Yxe0k++LA/UfFLF/@coredump.intra.peff.net> (raw)

While looking at something unrelated, I noticed that "git rev-list
--verify-objects" will not actually notice corruptions of commits that
are found in a commit graph. This fixes it.

The first one is a cleanup that is not strictly related, but is needed
for the tests in the second to work reliably (and is a good idea
anyway).

The second is the fix. I don't think it's super-important, as we do not
use --verify-objects for anything, since d21c463d55 (fetch/receive:
remove over-pessimistic connectivity check, 2012-03-15). And it's not
even documented, so perhaps we should just consider getting rid of it.
But in the meantime, it was easy enough to correct.

  [1/2]: lookup_commit_in_graph(): use prepare_commit_graph() to check for graph
  [2/2]: rev-list: disable commit graph with --verify-objects

 commit-graph.c  |  2 +-
 revision.c      |  1 +
 t/t1450-fsck.sh | 28 ++++++++++++++++++++++++++++
 3 files changed, 30 insertions(+), 1 deletion(-)

-Peff

             reply	other threads:[~2022-09-06 20:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-06 20:58 Jeff King [this message]
2022-09-06 21:02 ` [PATCH 1/2] lookup_commit_in_graph(): use prepare_commit_graph() to check for graph Jeff King
2022-09-06 21:16   ` Taylor Blau
2022-09-06 21:04 ` [PATCH 2/2] rev-list: disable commit graph with --verify-objects Jeff King
2022-09-06 21:20   ` Taylor Blau
2022-09-07 16:38   ` Junio C Hamano
2022-09-06 21:20 ` [PATCH 0/2] bug with rev-list --verify-objects and commit-graph Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yxe0k++LA/UfFLF/@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).