From: Jeff King <peff@peff.net>
To: Derrick Stolee <derrickstolee@github.com>
Cc: 程洋 <chengyang@xiaomi.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
何浩 <hehao@xiaomi.com>, "Xin7 Ma 马鑫" <maxin7@xiaomi.com>,
石奉兵 <shifengbing@xiaomi.com>, 凡军辉 <fanjunhui@xiaomi.com>,
王汉基 <wanghanji@xiaomi.com>
Subject: Re: [PATCH 2/3] upload-pack: skip parse-object re-hashing of "want" objects
Date: Wed, 7 Sep 2022 16:50:11 -0400 [thread overview]
Message-ID: <YxkEAx/qq5Rmn/Yx@coredump.intra.peff.net> (raw)
In-Reply-To: <3f901613-72c6-b644-079a-f74e3024a8fe@github.com>
On Wed, Sep 07, 2022 at 10:45:39AM -0400, Derrick Stolee wrote:
> After writing this, it was bothering me that 'rev-list --verify' should
> be checking for corruption throughout the history, not just at the tips.
>
> This is done via the condition in builtin/rev-list.c:finish_object():
>
> static int finish_object(struct object *obj, const char *name, void *cb_data)
> {
> struct rev_list_info *info = cb_data;
> if (oid_object_info_extended(the_repository, &obj->oid, NULL, 0) < 0) {
> finish_object__ma(obj);
> return 1;
> }
> if (info->revs->verify_objects && !obj->parsed && obj->type != OBJ_COMMIT)
> parse_object(the_repository, &obj->oid);
> return 0;
> }
>
> So this call is the one that is used most-often by the rev-list command,
> but isn't necessary to update for the purpose of our desired speedup. This
> is another place where we would want to use read_object_file(). (It may even
> be the _only_ place, since finish_object() should be called even for the
> tip objects.)
Yeah, I think this is the only place. At least, if you remove the hash
check entirely, then this parse_object() is the only spots that causes a
problem (via the existing test in t1450).
> In case you think it is valuable to ensure we test both cases ("tip" and
> "not tip") I modified your test to have a third commit and test two rev-list
> calls:
I don't think it's important to test here, as we know we just touched
the tip code here. But also, that existing "rev-list --verify-objects"
test in t1450 is covering that case: it corrupts a blob that is
reachable from an otherwise good commit/tree.
We should also have tip and non-tip tests for commits, but I posted
those in a separate series. ;)
-Peff
next prev parent reply other threads:[~2022-09-07 20:50 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 8:09 Partial-clone cause big performance impact on server 程洋
2022-08-11 17:22 ` Jonathan Tan
2022-08-13 7:55 ` 回复: [External Mail]Re: " 程洋
2022-08-13 11:41 ` 程洋
2022-08-15 5:16 ` ZheNing Hu
2022-08-15 13:15 ` 程洋
2022-08-12 12:21 ` Derrick Stolee
2022-08-14 6:48 ` Jeff King
2022-08-15 13:18 ` Derrick Stolee
2022-08-15 14:50 ` [External Mail]Re: " 程洋
2022-08-17 10:22 ` 程洋
2022-08-17 13:41 ` Derrick Stolee
2022-08-18 5:49 ` Jeff King
2022-09-01 6:53 ` 程洋
2022-09-01 16:19 ` Jeff King
2022-09-05 11:17 ` 程洋
2022-09-06 18:38 ` Jeff King
2022-09-06 22:58 ` [PATCH 0/3] speeding up on-demand fetch for blobs in partial clone Jeff King
2022-09-06 23:01 ` [PATCH 1/3] parse_object(): allow skipping hash check Jeff King
2022-09-07 14:15 ` Derrick Stolee
2022-09-07 20:44 ` Jeff King
2022-09-06 23:05 ` [PATCH 2/3] upload-pack: skip parse-object re-hashing of "want" objects Jeff King
2022-09-07 14:36 ` Derrick Stolee
2022-09-07 14:45 ` Derrick Stolee
2022-09-07 20:50 ` Jeff King [this message]
2022-09-07 19:26 ` Junio C Hamano
2022-09-07 20:36 ` Jeff King
2022-09-07 20:48 ` [BUG] t1800: Fails for error text comparison rsbecker
2022-09-07 21:55 ` Junio C Hamano
2022-09-07 22:23 ` rsbecker
2022-09-07 21:02 ` [PATCH 2/3] upload-pack: skip parse-object re-hashing of "want" objects Jeff King
2022-09-07 22:07 ` Junio C Hamano
2022-09-08 5:04 ` Jeff King
2022-09-08 16:41 ` Junio C Hamano
2022-09-06 23:06 ` [PATCH 3/3] parse_object(): check commit-graph when skip_hash set Jeff King
2022-09-07 14:46 ` Derrick Stolee
2022-09-07 19:31 ` Junio C Hamano
2022-09-08 10:39 ` [External Mail]Re: " 程洋
2022-09-08 18:42 ` Jeff King
2022-09-07 14:48 ` [PATCH 0/3] speeding up on-demand fetch for blobs in partial clone Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxkEAx/qq5Rmn/Yx@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=chengyang@xiaomi.com \
--cc=derrickstolee@github.com \
--cc=fanjunhui@xiaomi.com \
--cc=git@vger.kernel.org \
--cc=hehao@xiaomi.com \
--cc=maxin7@xiaomi.com \
--cc=shifengbing@xiaomi.com \
--cc=wanghanji@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).