From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Cc: Derrick Stolee <derrickstolee@github.com>
Subject: [PATCH 0/5] plugging some list-objects-filter leaks
Date: Thu, 8 Sep 2022 00:52:20 -0400 [thread overview]
Message-ID: <Yxl1BNQoy6Drf0Oe@coredump.intra.peff.net> (raw)
The test I sent earlier in [1] fails the linux-leaks CI job, not because
it introduces new leaks, but just because it runs existing leaks in a
test marked as passing-leaks.
Of course we can drop the passing flag, but I figured it would probably
be an easy fix. Famous last words. It turned into quite a rabbit hole of
actual leaks (albeit small and bounded per process) and some
questionable memory ownership semantics.
Here's the series I came up with. I'm cc-ing Stolee as the last person
unfortunate enough to have touched this area. :)
[1/5]: list_objects_filter_copy(): deep-copy sparse_oid_name field
[2/5]: transport: deep-copy object-filter struct for fetch-pack
[3/5]: transport: free filter options in disconnect_git()
[4/5]: list_objects_filter_options: plug leak of filter_spec strings
[5/5]: prepare_repo_settings(): plug leak of config values
list-objects-filter-options.c | 20 ++++++++++++++------
repo-settings.c | 7 +++----
transport.c | 5 ++++-
3 files changed, 21 insertions(+), 11 deletions(-)
-Peff
[1] https://lore.kernel.org/git/YxkG3A30vNfu55Sx@coredump.intra.peff.net/
next reply other threads:[~2022-09-08 4:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 4:52 Jeff King [this message]
2022-09-08 4:54 ` [PATCH 1/5] list_objects_filter_copy(): deep-copy sparse_oid_name field Jeff King
2022-09-08 4:57 ` [PATCH 2/5] transport: deep-copy object-filter struct for fetch-pack Jeff King
2022-09-08 4:58 ` [PATCH 3/5] transport: free filter options in disconnect_git() Jeff King
2022-09-08 5:01 ` [PATCH 4/5] list_objects_filter_options: plug leak of filter_spec strings Jeff King
2022-09-08 5:02 ` [PATCH 5/5] prepare_repo_settings(): plug leak of config values Jeff King
2022-09-09 14:20 ` [PATCH 0/5] plugging some list-objects-filter leaks Derrick Stolee
2022-09-11 4:51 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yxl1BNQoy6Drf0Oe@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).