From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: LSan curiosity in t1300
Date: Thu, 8 Sep 2022 14:15:34 -0400 [thread overview]
Message-ID: <YxoxRus2NjsYmM63@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqq8rmtrbfq.fsf@gitster.g>
On Thu, Sep 08, 2022 at 11:03:05AM -0700, Junio C Hamano wrote:
> > But if you run this in a debugger, you'll find that under -O2 the "key"
> > variable has been optimized out! So LSan is producing the wrong result
> > due to the optimization. It doesn't know that "key" is conceptually
> > still reachable.
>
> Yikes.
>
> Is that related to the cause of the other patch from you, i.e.
> wanting to get "registers" but unable to? If they manage to get the
> value of the register that holds 'key', would this disappear, I
> wonder?
I don't think so. t1300 fails consistently for me with -O2, and it
doesn't have the "register" message (and never came up as one of the
racy losers). I think the "register" thing is mostly just a harmless
warning that doesn't change the output, but simply confuses our "did
lsan produce any logs" check.
-Peff
prev parent reply other threads:[~2022-09-08 18:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 5:29 LSan curiosity in t1300 Jeff King
2022-09-08 15:42 ` [PATCH] tests: opt "git --config-env" test out of SANITIZE=leak Ævar Arnfjörð Bjarmason
2022-09-08 18:40 ` Jeff King
2022-09-23 8:28 ` Ævar Arnfjörð Bjarmason
2022-09-23 21:01 ` Jeff King
2022-09-26 8:56 ` Ævar Arnfjörð Bjarmason
2022-09-08 18:03 ` LSan curiosity in t1300 Junio C Hamano
2022-09-08 18:15 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxoxRus2NjsYmM63@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).