From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Brijesh Patel <bridgepatel@gmail.com>, git@vger.kernel.org
Subject: Re: BUG: Value for GIT_SSL_NO_VERIFY has no effect
Date: Thu, 15 Sep 2022 16:15:35 +0000 [thread overview]
Message-ID: <YyNPp3UMCii67ugC@tapette.crustytoothpaste.net> (raw)
In-Reply-To: <xmqq8rmkpsit.fsf@gitster.g>
[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]
On 2022-09-15 at 15:27:22, Junio C Hamano wrote:
> I did a quick audit of the environment variables documented in
> git(1) and it is a bit messy. Many environment variables use
> git_env_bool() to make themselves a proper Boolean environment
> variable, but some others that are described to take "1" to "enable"
> do not honor the usual "yes/true/on" convention.
Yeah. I think we could well adjust this to accept "0" or "false" to
turn it off if we liked, but it doesn't right now. I think that could
well be valuable if we wanted to make a change in the future.
I could submit a patch to do this over the next couple of days for this
variable and GIT_CURL_VERBOSE as well if we decide we want to do so.
> SSL_NO_VERIFY is worse, as it is not even described. So we should
> add it to "git help git".
It is documented in git-config(1), but of course we should also document
in git(1) as suggested. Do you want to turn this into a nice patch or
would you prefer that I turned it into one with your sign-off?
--
brian m. carlson (he/him or they/them)
Toronto, Ontario, CA
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
next prev parent reply other threads:[~2022-09-15 16:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 1:46 BUG: Value for GIT_SSL_NO_VERIFY has no effect Brijesh Patel
2022-09-15 13:04 ` brian m. carlson
2022-09-15 15:27 ` Junio C Hamano
2022-09-15 16:06 ` [PATCH 0/5] Update docs on GIT_* environment variables Junio C Hamano
2022-09-15 16:06 ` [PATCH 1/5] environ: document GIT_SSL_NO_VERIFY Junio C Hamano
2022-09-15 16:06 ` [PATCH 2/5] environ: explain Boolean environment variables Junio C Hamano
2022-09-15 16:06 ` [PATCH 3/5] environ: GIT_FLUSH should be made a usual Boolean Junio C Hamano
2023-01-03 17:18 ` René Scharfe
2023-01-04 6:37 ` Junio C Hamano
2023-01-04 16:36 ` René Scharfe
2023-01-04 7:33 ` Jeff King
2023-01-04 16:36 ` René Scharfe
2023-01-06 9:10 ` Jeff King
2022-09-15 16:06 ` [PATCH 4/5] environ: simplify description of GIT_INDEX_FILE Junio C Hamano
2022-09-16 15:39 ` Todd Zullinger
2022-09-16 16:44 ` Junio C Hamano
2022-09-15 16:06 ` [PATCH 5/5] environ: GIT_INDEX_VERSION affects not just a new repository Junio C Hamano
2022-09-15 16:15 ` brian m. carlson [this message]
2022-09-15 18:05 ` BUG: Value for GIT_SSL_NO_VERIFY has no effect Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyNPp3UMCii67ugC@tapette.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=bridgepatel@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).