git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: jt/path-filter-fix (was: Re: What's cooking in git.git (Aug 2023, #01; Wed, 2))
Date: Wed, 2 Aug 2023 15:09:28 -0400	[thread overview]
Message-ID: <ZMqp6K2iXixWH/zT@nand.local> (raw)
In-Reply-To: <xmqqfs518gdh.fsf@gitster.g>

On Wed, Aug 02, 2023 at 11:10:34AM -0700, Junio C Hamano wrote:
> * jt/path-filter-fix (2023-08-01) 7 commits
>  - commit-graph: new filter ver. that fixes murmur3
>  - repo-settings: introduce commitgraph.changedPathsVersion
>  - t4216: test changed path filters with high bit paths
>  - t/helper/test-read-graph: implement `bloom-filters` mode
>  - bloom.h: make `load_bloom_filter_from_graph()` public
>  - t/helper/test-read-graph.c: extract `dump_graph_info()`
>  - gitformat-commit-graph: describe version 2 of BDAT
>
>  The Bloom filter used for path limited history traversal was broken
>  on systems whose "char" is unsigned; update the implementation and
>  bump the format version to 2.
>
>  Still under discussion.
>  cf. <20230801185232.1457172-1-jonathantanmy@google.com>
>  source: <cover.1690912539.git.jonathantanmy@google.com>

I am happy with the most recent round, but I think that it is probably a
little late in the cycle to be merging down such a large change.

I wouldn't be opposed if you did so, but it may be worth waiting until
we're on the other side of 2.42 so that other reviewers have a chance to
look at this one as well.

Thanks,
Taylor

  reply	other threads:[~2023-08-02 19:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-02 18:10 What's cooking in git.git (Aug 2023, #01; Wed, 2) Junio C Hamano
2023-08-02 19:09 ` Taylor Blau [this message]
2023-08-02 19:20   ` jt/path-filter-fix Junio C Hamano
2023-08-02 19:28     ` jt/path-filter-fix Taylor Blau
     [not found] ` <CAP8UFD1vuB2kRr890B7GXum9HAMjRep86zy2tE4yE2C3W5QGHA@mail.gmail.com>
2023-08-07 12:41   ` What's cooking in git.git (Aug 2023, #01; Wed, 2) Christian Couder
2023-08-07 16:19     ` Junio C Hamano
2023-08-07 16:22       ` Taylor Blau
2023-08-07 16:56       ` Elijah Newren
2023-08-17 13:21         ` Johannes Schindelin
2023-08-07 20:59 ` Rubén Justo
2023-08-08 19:22 ` leak in jt/path-filter-fix, was " Jeff King
2023-08-08 19:25   ` Jeff King
2023-08-08 20:22   ` Taylor Blau
2023-08-08 21:19     ` Jeff King
2023-08-11 22:15     ` Jonathan Tan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZMqp6K2iXixWH/zT@nand.local \
    --to=me@ttaylorr.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).