From: Dorcas Litunya <anonolitunya@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: christian.couder@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH] t/t7601: Modernize test scripts using functions
Date: Wed, 18 Oct 2023 15:52:10 +0300 [thread overview]
Message-ID: <ZS/U+rPzVCpzGMww@dorcaslitunya-virtual-machine> (raw)
In-Reply-To: <xmqqjzrlgftp.fsf@gitster.g>
On Tue, Oct 17, 2023 at 01:21:54PM -0700, Junio C Hamano wrote:
> Dorcas Litunya <anonolitunya@gmail.com> writes:
>
> > Bcc:
> > Subject: Re: [PATCH] t/t7601: Modernize test scripts using functions
> > Reply-To:
> > In-Reply-To: <xmqq1qdumrto.fsf@gitster.g>
>
> What are these lines doing here?
>
Sorry, I formatted the email wrongly.
> > So should I replace this in the next version or leave this as is?
>
> Perhaps I was not clear enough, but I found the commit title and
> description need to be updated to clearly record the intent of the
> change with a handful of points, so I will not be accepting the
> patch as-is.
>
> These two sections may be of help.
>
> Documentation/MyFirstContribution.txt::now-what
> Documentation/MyFirstContribution.txt::reviewing
>
Thanks for the resources and feedback. Ihave edited the patch based on
it and sent v2.
> Thanks.
next prev parent reply other threads:[~2023-10-18 12:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 18:43 Dorcas Litunya
2023-10-17 16:47 ` Re:[PATCH] t/t7601: Modernize test scripts using functions Dorcas Litunya
2023-10-17 20:21 ` none Junio C Hamano
2023-10-18 12:52 ` Dorcas Litunya [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-10-16 15:21 [PATCH] t/t7601: Modernize test scripts using functions Dorcas AnonoLitunya
2023-10-16 16:53 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZS/U+rPzVCpzGMww@dorcaslitunya-virtual-machine \
--to=anonolitunya@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).