git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <johannes.schindelin@gmx.de>
To: jhi@iki.fi
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: wishlist: make it possible to amend commit messages after push to remote
Date: Fri, 07 Aug 2015 21:38:27 +0200	[thread overview]
Message-ID: <a0b9f82a46f2887d3ff3fb392e2e4c2c@www.dscho.org> (raw)
In-Reply-To: <55C4E67F.7050109@iki.fi>

Hi,

On 2015-08-07 19:10, Jarkko Hietaniemi wrote:

> But to be honest, I wasn't expecting a miracle cure.  I guess the core
> of my gripe is just that: how the commit message is part of the SHA.

The commit message is not "part of the SHA" but it is part of the content that defines the SHA-1.

I guess in your case, you would rather have an empty commit message and attach the real message as a commit note.

Speaking for myself, I actually like it that the entire metadata is part of the commit object, even the commit message. It makes the whole thing more reliable: one cannot claim that the commit does one thing on one day, and the next day all of a sudden claim that the commit does something completely different. Git's just really consistent the way it is.

Ciao,
Johannes

  reply	other threads:[~2015-08-07 19:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-07  0:23 wishlist: make it possible to amend commit messages after push to remote Jarkko Hietaniemi
2015-08-07 16:09 ` Kevin Daudt
2015-08-07 17:14   ` Jarkko Hietaniemi
2015-08-07 21:02     ` Philip Oakley
2015-08-07 16:59 ` Junio C Hamano
2015-08-07 17:10   ` Jarkko Hietaniemi
2015-08-07 19:38     ` Johannes Schindelin [this message]
2015-08-07 22:50       ` Jarkko Hietaniemi
2015-08-08  9:24         ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a0b9f82a46f2887d3ff3fb392e2e4c2c@www.dscho.org \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jhi@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).