From: Ramsay Jones <ramsay@ramsayjones.plus.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Adam Dinwoodie <adam@dinwoodie.org>,
GIT Mailing-list <git@vger.kernel.org>, Jeff King <peff@peff.net>
Subject: Re: [RFC PATCH 1B] credential-cache--daemon: close input before exit-ing
Date: Thu, 7 Jul 2022 16:35:15 +0100 [thread overview]
Message-ID: <a26a837a-51f2-d38b-7eb4-8e425d6d9150@ramsayjones.plus.com> (raw)
In-Reply-To: <220707.86pmih847l.gmgdl@evledraar.gmail.com>
On 07/07/2022 14:00, Ævar Arnfjörð Bjarmason wrote:
>
> On Thu, Jul 07 2022, Ramsay Jones wrote:
>
>> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
>> ---
>> builtin/credential-cache--daemon.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/builtin/credential-cache--daemon.c b/builtin/credential-cache--daemon.c
>> index 4c6c89ab0d..556393498f 100644
>> --- a/builtin/credential-cache--daemon.c
>> +++ b/builtin/credential-cache--daemon.c
>> @@ -138,6 +138,7 @@ static void serve_one_client(FILE *in, FILE *out)
>> * process actually ends, which closes the socket and gives
>> * them EOF.
>> */
>> + fclose(in);
>> exit(0);
>> }
>> else if (!strcmp(action.buf, "erase"))
>
> This is called by a function that will also close stdout, shouldn't we
> be closing it here?
Err, do you mean 'out' rather than 'stdout'? Actually, it doesn't
matter either way! :)
Let me quote from [1], which (hopefully) explains the context:
"""
Anyway, I started playing around with flushing/closing of 'FILE *' streams
before the 'exit' call, to change the order, relative to the socket-file
deletion in the 'atexit' function (or the closing of the listen-socket
descriptor, come to that). In particular, I found that if I were to close
the 'in'put stream, then the client would receive an EOF and exit normally
(ie no error return from read_in_full() above).
[fclose(in); fclose(out) also works, but fclose(out) on its own does not.
fflush() in various combinations did not work at all].
"""
So, my intent was to find the _minimum_ change necessary to fix the test.
This is not a 'real' patch - it was only to demonstrate that there appears
to be some order dependency problem induced by the 'atexit' clean-up from
exit()-ing the server.
ATB,
Ramsay Jones
[1] https://lore.kernel.org/git/9dc3e85f-a532-6cff-de11-1dfb2e4bc6b6@ramsayjones.plus.com/
prev parent reply other threads:[~2022-07-07 15:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 1:54 [RFC PATCH 1B] credential-cache--daemon: close input before exit-ing Ramsay Jones
2022-07-07 13:00 ` Ævar Arnfjörð Bjarmason
2022-07-07 15:35 ` Ramsay Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a26a837a-51f2-d38b-7eb4-8e425d6d9150@ramsayjones.plus.com \
--to=ramsay@ramsayjones.plus.com \
--cc=adam@dinwoodie.org \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).