git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] t7004: don't create unused file
@ 2019-12-11 18:46 René Scharfe
  2019-12-11 18:59 ` Derrick Stolee
  0 siblings, 1 reply; 2+ messages in thread
From: René Scharfe @ 2019-12-11 18:46 UTC (permalink / raw)
  To: Git Mailing List; +Cc: Junio C Hamano

msgfile2 became unused with 3968658599 (Make builtin-tag.c use
parse_options., 2007-11-09), get rid of it.

Signed-off-by: René Scharfe <l.s.r@web.de>
---
 t/t7004-tag.sh | 1 -
 1 file changed, 1 deletion(-)

diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh
index 4a09bea1d6..6db92bd3ba 100755
--- a/t/t7004-tag.sh
+++ b/t/t7004-tag.sh
@@ -517,7 +517,6 @@ test_expect_success \
 test_expect_success \
 	'trying to create tags giving both -m or -F options should fail' '
 	echo "message file 1" >msgfile1 &&
-	echo "message file 2" >msgfile2 &&
 	! tag_exists msgtag &&
 	test_must_fail git tag -m "message 1" -F msgfile1 msgtag &&
 	! tag_exists msgtag &&
--
2.24.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] t7004: don't create unused file
  2019-12-11 18:46 [PATCH] t7004: don't create unused file René Scharfe
@ 2019-12-11 18:59 ` Derrick Stolee
  0 siblings, 0 replies; 2+ messages in thread
From: Derrick Stolee @ 2019-12-11 18:59 UTC (permalink / raw)
  To: René Scharfe, Git Mailing List; +Cc: Junio C Hamano

On 12/11/2019 1:46 PM, René Scharfe wrote:
> diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh
> index 4a09bea1d6..6db92bd3ba 100755
> --- a/t/t7004-tag.sh
> +++ b/t/t7004-tag.sh
> @@ -517,7 +517,6 @@ test_expect_success \
>  test_expect_success \
>  	'trying to create tags giving both -m or -F options should fail' '
>  	echo "message file 1" >msgfile1 &&
> -	echo "message file 2" >msgfile2 &&

Obviously correct.

-Stolee


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-12-11 18:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-11 18:46 [PATCH] t7004: don't create unused file René Scharfe
2019-12-11 18:59 ` Derrick Stolee

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).