From: Phillip Wood <phillip.wood123@gmail.com>
To: Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Cc: gitster@pobox.com, sandals@crustytoothpaste.net,
lenaic@lhuard.fr, Derrick Stolee <derrickstolee@github.com>,
Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH 6/6] maintenance: use random minute in systemd scheduler
Date: Tue, 8 Aug 2023 10:53:56 +0100 [thread overview]
Message-ID: <adc0cf80-c2e3-7af2-6d7f-036b95d27f80@gmail.com> (raw)
In-Reply-To: <14e340b75faaa66980479f42fec14c457aea5c74.1691434300.git.gitgitgadget@gmail.com>
Hi Stolee
On 07/08/2023 19:51, Derrick Stolee via GitGitGadget wrote:
> From: Derrick Stolee <derrickstolee@github.com>
> + switch (schedule) {
> + case SCHEDULE_HOURLY:
> + schedule_pattern = xstrfmt("*-*-* *:%02d:00", minute);
> + break;
> +
> + case SCHEDULE_DAILY:
> + schedule_pattern = xstrfmt("*-*-* 0:%02d:00", minute);
> + break;
> +
> + case SCHEDULE_WEEKLY:
> + schedule_pattern = xstrfmt("Mon 0:%02d:00", minute);
> + break;
This is not a new issue with this patch but we run the hourly job even
when we want to run the daily job or the weekly job and we run the daily
job when we want to run the weekly job. maintenance_run_tasks() contains
if (hold_lock_file_for_update(&lk, lock_path, LOCK_NO_DEREF) < 0) {
/*
* Another maintenance command is running.
*
* If --auto was provided, then it is likely due to a
* recursive process stack. Do not report an error in
* that case.
*/
if (!opts->auto_flag && !opts->quiet)
warning(_("lock file '%s' exists, skipping maintenance"),
lock_path);
free(lock_path);
return 0;
}
So only one of these jobs will succeed. The cron entries are careful to
only run one job at a time, I think it would be worth doing the same
thing here. I think the using the following format strings would fix this.
Hourly: "Tue..Sun *-*-* 1..23:00:%02d"
Daily: "Tue..Sun *-*-* 00:00:%02d"
Weekly: "Mon *-*-* 00:00:%02d"
It looks like the launchctl schedule has the same issue.
One thing I've been wondering about which is related to maintenance but
totally off-topic for this patch is that I think when auto maintenance
is enabled we stop automatically running "gc" so how do the reflogs get
expired?
Best Wishes
Phillip
next prev parent reply other threads:[~2023-08-08 16:23 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 18:51 [PATCH 0/6] maintenance: schedule maintenance on a random minute Derrick Stolee via GitGitGadget
2023-08-07 18:51 ` [PATCH 1/6] maintenance: add get_random_minute() Derrick Stolee via GitGitGadget
2023-08-07 21:20 ` Taylor Blau
2023-08-07 23:53 ` Junio C Hamano
2023-08-08 0:22 ` Junio C Hamano
2023-08-08 14:48 ` Taylor Blau
2023-08-08 16:34 ` Junio C Hamano
2023-08-08 16:49 ` Junio C Hamano
2023-08-08 20:01 ` Taylor Blau
2023-08-08 17:28 ` Derrick Stolee
2023-08-08 20:04 ` Taylor Blau
2023-08-09 12:17 ` Derrick Stolee
2023-08-09 18:50 ` Junio C Hamano
2023-08-09 20:34 ` Taylor Blau
2023-08-07 18:51 ` [PATCH 2/6] maintenance: use random minute in launchctl scheduler Derrick Stolee via GitGitGadget
2023-08-07 21:23 ` Taylor Blau
2023-08-07 18:51 ` [PATCH 3/6] maintenance: use random minute in Windows scheduler Derrick Stolee via GitGitGadget
2023-08-07 18:51 ` [PATCH 4/6] maintenance: use random minute in cron scheduler Derrick Stolee via GitGitGadget
2023-08-07 18:51 ` [PATCH 5/6] maintenance: swap method locations Derrick Stolee via GitGitGadget
2023-08-07 21:24 ` Taylor Blau
2023-08-07 18:51 ` [PATCH 6/6] maintenance: use random minute in systemd scheduler Derrick Stolee via GitGitGadget
2023-08-07 21:31 ` Taylor Blau
2023-08-08 13:49 ` Derrick Stolee
2023-08-08 20:05 ` Taylor Blau
2023-08-08 9:53 ` Phillip Wood [this message]
2023-08-08 13:03 ` Phillip Wood
2023-08-08 13:56 ` Derrick Stolee
2023-08-08 17:24 ` Derrick Stolee
2023-08-09 10:03 ` Phillip Wood
2023-08-08 12:08 ` Phillip Wood
2023-08-08 17:06 ` Derrick Stolee
2023-08-08 17:14 ` Derrick Stolee
2023-08-09 10:00 ` Phillip Wood
2023-08-10 20:39 ` [PATCH v2 0/8] maintenance: schedule maintenance on a random minute Derrick Stolee via GitGitGadget
2023-08-10 20:39 ` [PATCH v2 1/8] maintenance: add get_random_minute() Derrick Stolee via GitGitGadget
2023-08-10 21:25 ` Taylor Blau
2023-08-10 20:39 ` [PATCH v2 2/8] maintenance: use random minute in launchctl scheduler Derrick Stolee via GitGitGadget
2023-08-10 20:39 ` [PATCH v2 3/8] maintenance: use random minute in Windows scheduler Derrick Stolee via GitGitGadget
2023-08-10 20:39 ` [PATCH v2 4/8] maintenance: use random minute in cron scheduler Derrick Stolee via GitGitGadget
2023-08-10 20:39 ` [PATCH v2 5/8] maintenance: swap method locations Derrick Stolee via GitGitGadget
2023-08-10 20:39 ` [PATCH v2 6/8] maintenance: use random minute in systemd scheduler Derrick Stolee via GitGitGadget
2023-08-14 11:26 ` Phillip Wood
2023-08-10 20:39 ` [PATCH v2 7/8] maintenance: fix systemd schedule overlaps Derrick Stolee via GitGitGadget
2023-08-10 21:22 ` Junio C Hamano
2023-08-14 11:27 ` Phillip Wood
2023-08-10 20:39 ` [PATCH v2 8/8] maintenance: update schedule before config Derrick Stolee via GitGitGadget
2023-08-14 11:28 ` Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adc0cf80-c2e3-7af2-6d7f-036b95d27f80@gmail.com \
--to=phillip.wood123@gmail.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=lenaic@lhuard.fr \
--cc=me@ttaylorr.com \
--cc=phillip.wood@dunelm.org.uk \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).