From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jeff King <peff@peff.net>
Cc: "René Scharfe" <l.s.r@web.de>,
"Junio C Hamano" <gitster@pobox.com>,
"Git List" <git@vger.kernel.org>
Subject: Re: [DEMO][PATCH v2 6/5] compat: add a qsort_s() implementation based on GNU's qsort_r(1)
Date: Thu, 26 Jan 2017 14:49:10 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1701261446540.3469@virtualbox> (raw)
In-Reply-To: <20170125185153.obqwxiniyz2omxsi@sigill.intra.peff.net>
[-- Attachment #1: Type: text/plain, Size: 425 bytes --]
Hi,
On Wed, 25 Jan 2017, Jeff King wrote:
> On Wed, Jan 25, 2017 at 07:43:01PM +0100, René Scharfe wrote:
>
> > If we find such cases then we'd better fix them for all platforms, e.g. by
> > importing timsort, no?
>
> Yes, as long as they are strict improvements.
I think in many cases, we may be better off by replacing the use of a
string-list for lookups by hashmaps for the same purpose.
Ciao,
Dscho
next prev parent reply other threads:[~2017-01-26 13:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-22 17:47 [PATCH v2 0/5] string-list: make string_list_sort() reentrant René Scharfe
2017-01-22 17:51 ` [PATCH v2 1/5] compat: add qsort_s() René Scharfe
2017-01-22 17:52 ` [PATCH v2 2/5] add QSORT_S René Scharfe
2017-01-22 17:53 ` [PATCH v2 3/5] perf: add basic sort performance test René Scharfe
2017-01-22 17:57 ` [PATCH v2 4/5] string-list: use QSORT_S in string_list_sort() René Scharfe
2017-01-22 17:58 ` [PATCH v2 5/5] ref-filter: use QSORT_S in ref_array_sort() René Scharfe
2017-01-22 18:02 ` [DEMO][PATCH v2 6/5] compat: add a qsort_s() implementation based on GNU's qsort_r(1) René Scharfe
2017-01-23 19:07 ` Junio C Hamano
2017-01-24 18:00 ` René Scharfe
2017-01-24 20:39 ` Jeff King
2017-01-25 18:43 ` René Scharfe
2017-01-25 18:51 ` Jeff King
2017-01-26 13:49 ` Johannes Schindelin [this message]
2017-01-23 23:54 ` [PATCH v2 0/5] string-list: make string_list_sort() reentrant Jeff King
2017-01-24 11:44 ` Johannes Schindelin
2017-01-24 13:44 ` Jeff King
2017-01-24 18:00 ` René Scharfe
2017-01-24 20:41 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1701261446540.3469@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).