From: Nicolas Pitre <nico@cam.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH] gc: call "prune --expire 2.weeks.ago"
Date: Tue, 11 Mar 2008 22:37:09 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.1.00.0803112234470.2947@xanadu.home> (raw)
In-Reply-To: <7vskywadum.fsf@gitster.siamese.dyndns.org>
On Tue, 11 Mar 2008, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > If "--prune" is passed to gc, it still just calls "git prune".
> > Otherwise, "prune --expire 2.weeks.ago" is called, where the grace
> > period is overrideable by the config variable gc.pruneExpire.
>
> "What it does."
>
> > While adding a test to t5304-prune.sh (since it really tests the
> > implicit call to "prune"), the original test for "prune --expire"
> > is moved there from t1410-reflog.sh, where it did not belong.
>
> "What the fallouts from this change were."
>
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> Can we also have "why this is a good idea", "what problem this solves"?
FWIW, my agreeing with the "why this is a good idea" can be translated
into:
Acked-by: Nicolas Pitre <nico@cam.org>
Nicolas
next prev parent reply other threads:[~2008-03-12 2:38 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-11 20:58 [PATCH] gc: call "prune --expire 2.weeks.ago" Johannes Schindelin
2008-03-12 2:13 ` Junio C Hamano
2008-03-12 2:37 ` Nicolas Pitre [this message]
2008-03-12 6:49 ` Junio C Hamano
2008-03-12 10:57 ` Johannes Schindelin
2008-03-12 15:45 ` Nicolas Pitre
2008-03-12 15:53 ` Pieter de Bie
2008-03-12 16:05 ` Johannes Schindelin
2008-03-12 17:01 ` Jeff King
2008-03-12 22:50 ` Pieter de Bie
2008-03-12 23:20 ` Junio C Hamano
2008-03-12 23:30 ` Johannes Schindelin
2008-03-12 23:41 ` Junio C Hamano
2008-03-12 16:20 ` Geert Bosch
2008-03-12 15:07 ` Nicolas Pitre
2008-03-12 15:32 ` Marko Kreen
2008-03-12 17:35 ` [PATCH v2] gc: call "prune --expire 2.weeks.ago" by default Johannes Schindelin
2008-03-12 17:56 ` Brandon Casey
2008-03-12 18:35 ` Jakub Narebski
2008-03-12 19:07 ` Johannes Schindelin
2008-03-12 19:12 ` Junio C Hamano
2008-03-12 19:38 ` Johannes Schindelin
2008-03-12 19:53 ` [PATCH v3] " Johannes Schindelin
2008-03-12 19:55 ` Johannes Schindelin
2008-03-12 19:55 ` [PATCH v2] " Brandon Casey
2008-03-12 19:59 ` Johannes Schindelin
2008-03-12 20:25 ` Brandon Casey
2008-03-12 20:35 ` Junio C Hamano
2008-03-12 20:55 ` [PATCH v4] " Johannes Schindelin
2008-03-12 20:56 ` Johannes Schindelin
2008-03-12 21:20 ` Junio C Hamano
2008-03-12 22:40 ` Nicolas Pitre
2008-03-12 22:50 ` Johannes Schindelin
2008-03-12 23:13 ` Junio C Hamano
2008-03-12 23:28 ` Johannes Schindelin
2008-03-12 23:39 ` Junio C Hamano
2008-03-12 23:43 ` Johannes Schindelin
2008-03-13 9:48 ` Wincent Colaiuta
2008-03-13 10:17 ` Johannes Sixt
2008-03-13 9:21 ` Wincent Colaiuta
2008-03-13 11:11 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.00.0803112234470.2947@xanadu.home \
--to=nico@cam.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).