git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Peter Karlsson <peter@softwolves.pp.se>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] bisect view: check for MinGW32 and MacOSX in addition to X11
Date: Mon, 10 Mar 2008 19:20:10 +0100 (CET)	[thread overview]
Message-ID: <alpine.LSU.1.00.0803101919060.3975@racer.site> (raw)
In-Reply-To: <Pine.LNX.4.64.0802151346000.18292@ds9.cixit.se>

Hi,

On Fri, 15 Feb 2008, Peter Karlsson wrote:

> Johannes Schindelin:
> 
> > Can you please test?  The we could at least add a "Tested-by:" to the 
> > commit message.
> 
> When starting from the "Git bash" shell, it works.
> 
> When starting from a Cygwin prompt, it does not work ($MSYSTEM is not 
> set).

Can you please test this patch (both from interactive and ssh'ed 
sessions)?

-- snipsnap --
[PATCH] bisect view: call gitk if Cygwin's SESSIONNAME variable is set

It seems that Cygwin sets the variable SESSIONNAME when an interactive
session is running, and does not set it when you log in via ssh.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 git-bisect.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-bisect.sh b/git-bisect.sh
index 2c32d0b..af8f9e3 100755
--- a/git-bisect.sh
+++ b/git-bisect.sh
@@ -333,7 +333,7 @@ bisect_visualize() {
 
 	if test $# = 0
 	then
-		case "${DISPLAY+set}${MSYSTEM+set}${SECURITYSESSIONID+set}" in
+		case "${DISPLAY+set}${SESSIONNAME+set}${MSYSTEM+set}${SECURITYSESSIONID+set}" in
 		'')	set git log ;;
 		set*)	set gitk ;;
 		esac
-- 
1.5.4.4.643.g7cb9b.dirty

  parent reply	other threads:[~2008-03-10 18:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-14 12:29 [PATCH] bisect view: check for MinGW32 and MacOSX in addition to X11 Johannes Schindelin
2008-02-15  9:40 ` Peter Karlsson
2008-02-15 10:51   ` Johannes Schindelin
2008-02-15 12:46     ` Peter Karlsson
2008-02-15 12:50       ` Johannes Schindelin
2008-03-10 18:20       ` Johannes Schindelin [this message]
2008-03-13 19:19         ` Peter Karlsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LSU.1.00.0803101919060.3975@racer.site \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=peter@softwolves.pp.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).