From: Ben Keene <seraphire@gmail.com>
To: Yang Zhao <yang.zhao@skyboxlabs.com>, Denton Liu <liu.denton@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 00/13] git-p4: python3 compatibility
Date: Sat, 7 Dec 2019 11:21:01 -0500 [thread overview]
Message-ID: <b21d153a-02f9-b9a1-7388-59b5a882d4f2@gmail.com> (raw)
In-Reply-To: <CABvFv3+viMXJO0z5HAQbCya7MU9tWd7P_LxUhu66T74XGN99yA@mail.gmail.com>
On 12/7/2019 2:29 AM, Yang Zhao wrote:
> On Fri, Dec 6, 2019 at 5:09 PM Denton Liu <liu.denton@gmail.com> wrote:
>> On Fri, Dec 06, 2019 at 04:33:18PM -0800, Yang Zhao wrote:
>>> This patchset adds python3 compatibility to git-p4.
>>> ...
>> Currently, there's a competing effort to do the same thing[1] by Ben
>> Keene (CC'd). Like the last time[2] two competing topics arose at the
>> same time, I'm going to make the same suggestion.
>>
>> Would it be possible for both of you to join forces?
> Yes, I do believe we are aware of each other's efforts. I had submitted
> an RFC patch set around the time Ben was preparing his own patchset.
> I have not reviewed Ben's first patchset as I did not feel that I understood
> the systems well enough at the time. I've briefly skimmed through Ben's latest
> iteration and it would appear the general approach is very similar, but there's
> more added abstractions and just general code change in his version.
>
> Regardless, I'm open to working together.
I am also open to working together, and could really use the help, as I'm
not a python developer.
I have taken all the suggestions from my first patch set and have reworked
my code and commits and will submit them now for review. With the smaller
patches and cleaner commit messages I hope that it will make it easier
to see what I've done so far and what is still open work.
> Ideally, I would prefer we land something minimal and working in mainline soon,
> then further collaborate on changes that clean up code and enable more features.
>
> My end-game is to have P4 Streams working in git-p4, and maybe LFS-like support
> that uses p4 as the backend. It would be great to not be the only one
> spending effort
> in that direction.
>
> Yang
I have similar goals. I would love to get the smallest set of non-breaking
changes in that allows the program to basically work with Python 3.5+.
My rush has been because I need to use git-p4 for work and have been
working
on the project at the office. Once I reach a point where I am able to
generally work (when t9800 is complete) I'll really not be free to spend
too
much work time on the project, but I am eager to see this through!
As far as status, the last time I ran tests, python 2.7 passed all the tests
and Python 3.5 passed some of the tests. I know it is not passing t9801
at this time and I'm trying to find out why.
So, Yang, I am very interested in working together.
Kindest regards,
Ben Keene
next prev parent reply other threads:[~2019-12-07 16:21 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-07 0:33 [PATCH 00/13] git-p4: python3 compatibility Yang Zhao
2019-12-07 0:33 ` [PATCH 01/13] ci: also run linux-gcc pipeline with python-3.7 environment Yang Zhao
2019-12-10 10:30 ` SZEDER Gábor
2019-12-10 19:11 ` Yang Zhao
2019-12-12 14:13 ` SZEDER Gábor
2019-12-12 17:04 ` Yang Zhao
2019-12-12 17:15 ` SZEDER Gábor
2019-12-12 19:02 ` Yang Zhao
2019-12-07 0:33 ` [PATCH 02/13] git-p4: make python-2.7 the oldest supported version Yang Zhao
2019-12-07 0:33 ` [PATCH 03/13] git-p4: simplify python version detection Yang Zhao
2019-12-07 0:33 ` [PATCH 04/13] git-p4: decode response from p4 to str for python3 Yang Zhao
2019-12-07 0:33 ` [PATCH 05/13] git-p4: properly encode/decode communication with git for python 3 Yang Zhao
2019-12-07 0:33 ` [PATCH 06/13] git-p4: convert path to unicode before processing them Yang Zhao
2019-12-07 0:33 ` [PATCH 06/13] git-p4: open .gitp4-usercache.txt in text mode Yang Zhao
2019-12-07 0:33 ` [PATCH 07/13] git-p4: convert path to unicode before processing them Yang Zhao
2019-12-07 0:33 ` [PATCH 07/13] git-p4: open .gitp4-usercache.txt in text mode Yang Zhao
2019-12-07 0:33 ` [PATCH 08/13] git-p4: use marshal format version 2 when sending to p4 Yang Zhao
2019-12-07 0:33 ` [PATCH 09/13] git-p4: fix freezing while waiting for fast-import progress Yang Zhao
2019-12-07 0:33 ` [PATCH 10/13] git-p4: use functools.reduce instead of reduce Yang Zhao
2019-12-07 0:33 ` [PATCH 11/13] git-p4: use dict.items() iteration for python3 compatibility Yang Zhao
2019-12-07 0:33 ` [PATCH 12/13] git-p4: simplify regex pattern generation for parsing diff-tree Yang Zhao
2019-12-07 0:33 ` [PATCH 13/13] git-p4: use python3's input() everywhere Yang Zhao
2019-12-07 1:09 ` [PATCH 00/13] git-p4: python3 compatibility Denton Liu
2019-12-07 7:29 ` Yang Zhao
2019-12-07 16:21 ` Ben Keene [this message]
2019-12-07 19:59 ` Yang Zhao
2019-12-09 15:03 ` Ben Keene
2019-12-09 18:54 ` Ben Keene
2019-12-09 19:48 ` Johannes Schindelin
2019-12-10 14:20 ` Ben Keene
2019-12-09 20:21 ` Yang Zhao
2019-12-13 17:10 ` Ben Keene
2019-12-07 7:34 ` Yang Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b21d153a-02f9-b9a1-7388-59b5a882d4f2@gmail.com \
--to=seraphire@gmail.com \
--cc=git@vger.kernel.org \
--cc=liu.denton@gmail.com \
--cc=yang.zhao@skyboxlabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).