Git Mailing List Archive on lore.kernel.org
 help / color / Atom feed
From: "Daniel Richard G." <skunk@iSKUNK.ORG>
To: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Minor portability issues + fixes
Date: Tue, 19 May 2020 00:26:02 -0400
Message-ID: <bbaacb8f-e2d3-4c4a-98d7-acea0b637081@www.fastmail.com> (raw)
In-Reply-To: <20200519030440.GB20332@Carlos-MBP>

Hi Carlo,

On Mon, 2020 May 18 23:04-04:00, Carlo Marcelo Arenas Belón wrote:
> On Mon, May 18, 2020 at 09:15:58PM -0400, Daniel Richard G. wrote:
> > 
> > I am building Git 2.26.2 on AIX. A few compilation errors arose, but
> > they are resolvable with a few minor changes that will improve overall
> > portability.
> 
> which version of AIX is this?

4.3, believe it or not :-]  This system is used for compatibility
testing of a legacy product.

> we include inttypes.h which is supposed to include stdint.h per POSIX[1]
> 
> could you take a look at that header and see if there is some macro definition
> preventing that to happen?

There's no #include at all, and stdint.h is not present under
/usr/include/. But I am building with GCC 4.7 (as the original
vendor compiler has outlived its usefulness), and that provides a
modern stdint.h.

The original inttypes.h is fixincluded by GCC, but this did not add the
stdint.h #include.

As I remarked to Jeff, would it be kosher to #include both inttypes.h
and stdint.h if both are present? It seems that most of the time, the
latter would be a no-op.


--Daniel


-- 
Daniel Richard G. || skunk@iSKUNK.ORG
My ASCII-art .sig got a bad case of Times New Roman.

      reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19  1:15 Daniel Richard G.
2020-05-19  2:49 ` Jeff King
2020-05-19  4:22   ` Daniel Richard G.
2020-05-20  4:28     ` Jeff King
2020-05-21  4:29       ` Daniel Richard G.
2020-05-22 20:03         ` Jeff King
2020-05-19  3:04 ` Carlo Marcelo Arenas Belón
2020-05-19  4:26   ` Daniel Richard G. [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bbaacb8f-e2d3-4c4a-98d7-acea0b637081@www.fastmail.com \
    --to=skunk@iskunk.org \
    --cc=carenas@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Mailing List Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/git/0 git/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 git git/ https://lore.kernel.org/git \
		git@vger.kernel.org
	public-inbox-index git

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.git


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git