From: "René Scharfe" <l.s.r@web.de>
To: Jeff King <peff@peff.net>
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] ls-files: don't try to prune an empty index
Date: Sun, 16 Jul 2017 13:32:19 +0200 [thread overview]
Message-ID: <c408be84-c35f-bf3a-4699-9dd0b5de93ef@web.de> (raw)
In-Reply-To: <31e6bebd-f2f5-b85d-2865-49611aecb2b8@web.de>
Am 16.07.2017 um 13:15 schrieb René Scharfe:
> Am 16.07.2017 um 13:08 schrieb Jeff King:
>> On Sun, Jul 16, 2017 at 01:06:45PM +0200, René Scharfe wrote:
>>
>>>>> diff --git a/builtin/ls-files.c b/builtin/ls-files.c
>>>>> index b8514a0029..adf572da68 100644
>>>>> --- a/builtin/ls-files.c
>>>>> +++ b/builtin/ls-files.c
>>>>> @@ -362,7 +362,7 @@ static void prune_index(struct index_state
>>>>> *istate,
>>>>> int pos;
>>>>> unsigned int first, last;
>>>>>
>>>>> - if (!prefix)
>>>>> + if (!prefix || !istate->cache_nr)
>>>>> return;
>>>>> pos = index_name_pos(istate, prefix, prefixlen);
>>>>> if (pos < 0)
>>>>
>>>> "git am" complained that this does not apply to its blobs. Did you
>>>> hand-edit?
>>>
>>> I didn't, but perhaps I messed up the order of patches? MOVE_ARRAY
>>> patch 2 touches the same file, but I wouldn't expect the two changes to
>>> conflict. So not sure what's going on.
>>
>> For some reason there's an extra space before the tab on each of the
>> context lines. MUA issue or cut-and-paste, maybe?
>
> That's possible. Will resend.
... pressed Send to fast. Thanks for reporting the broken patch!
I use the extension Toggle Word Wrap with Thunderbird, but it wraps by
default with no way to change that, so I forgot toggling this time.
Grr, I've had enough of this! Went past the warranty warning and set
mailnews.wraplength=0 now.
René
next prev parent reply other threads:[~2017-07-16 11:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-15 20:11 [PATCH] ls-files: don't try to prune an empty index René Scharfe
2017-07-16 0:28 ` Ramsay Jones
2017-07-16 3:52 ` René Scharfe
2017-07-16 10:41 ` Jeff King
2017-07-16 11:06 ` René Scharfe
2017-07-16 11:08 ` Jeff King
2017-07-16 11:15 ` René Scharfe
2017-07-16 11:32 ` René Scharfe [this message]
2017-07-16 11:16 ` [PATCH (resend)] " René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c408be84-c35f-bf3a-4699-9dd0b5de93ef@web.de \
--to=l.s.r@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).