From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AC98C432C0 for ; Tue, 26 Nov 2019 01:18:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 29B7D2068F for ; Tue, 26 Nov 2019 01:18:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ooQtsnJB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727285AbfKZBSb (ORCPT ); Mon, 25 Nov 2019 20:18:31 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:44444 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727091AbfKZBSb (ORCPT ); Mon, 25 Nov 2019 20:18:31 -0500 Received: by mail-pl1-f193.google.com with SMTP id az9so7329371plb.11 for ; Mon, 25 Nov 2019 17:18:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=oSYv3IDSDLX8QBH2hFjskq7DU0N5bdk2cfFPPNtUL5s=; b=ooQtsnJBb3TqNY9fv2DeDQTfNkjOAEHMtrDGU1zjuoK4Q0txz+iut1rfZ9CiL6A0md fsf4QtL3MH7fgHFFTaOSXNCnRQ0k2T7VzFdyDRtjc/2ekT6Hghcx3f3uM8CHKI2Aks+/ WJCO0n2ADre1pR/Da95AbzWygoioFbfvSPqlEysTP6g7UfN/Nktcu+WnWXOStXZ5fe3f EyAvldds8CaaCboWatkOyv+3x9t27DXpE5KGRkp3lDQgxJyZQLTw8oBLqzNs6X4bN5po PdhUUBbYGUOHJRyaU4orXkILoxzifiPQSKOoAGa0NZJ1aNr+1Iv4KgxAWufo0Du8ZHq9 /mww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=oSYv3IDSDLX8QBH2hFjskq7DU0N5bdk2cfFPPNtUL5s=; b=Z1z8eNOgyVEf2VZ9rvlS3yTTO2/hzjDL7iVRn1NgWsDHvKFHbDdfweCI3IdCLVTxEe 05cGD5Jn5md/GQf7tXXNS7eWo/6OY9QC65xyZIApAiHHWTjKl4EJmxUljI69eRCf3QqY sf5WSo0ICgmK/eFwlhH5AAPzC7Efw8fE0AHe1aUttsRlAvhY+ugzSr0Q0oh8vGYlGLS4 qEtyvRV7zyfE8REi+yBw2k8awIO0Mj07E7d1VyTbk3fx/YjoTXIjRicOJpsY+VCE+o9k XjzD1VuYZwBEB15BNGWW7Osw9XkVIai1nur7i139YnjJbYB2pvwaZiLpEwFTcM73ZBaL vfmg== X-Gm-Message-State: APjAAAWvWcNxSyCLMDwkBUEukWmr65/rBZR06EtzGn5w1HWBB3GRbfah rSzeTdfMxwlIVX6xgNQPowk+Paqy X-Google-Smtp-Source: APXvYqy7QGQyFodTNzxyZEjcm8Kxc1Vikui9l+N5lLiNncmlDVVrU9dZEHEGcHq3wJVtoHkD48UQ7Q== X-Received: by 2002:a17:902:6bc6:: with SMTP id m6mr3381978plt.83.1574731109828; Mon, 25 Nov 2019 17:18:29 -0800 (PST) Received: from generichostname ([204.14.239.138]) by smtp.gmail.com with ESMTPSA id w10sm9762427pgi.47.2019.11.25.17.18.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Nov 2019 17:18:29 -0800 (PST) Date: Mon, 25 Nov 2019 17:18:27 -0800 From: Denton Liu To: Git Mailing List Cc: Eric Sunshine , Junio C Hamano , Jeff King Subject: [PATCH v4 18/27] t7700: drop redirections to /dev/null Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Since output is silenced when running without `-v` and debugging output is useful with `-v`, remove redirections to /dev/null as it is not useful. In one case where the output of stdout is consumed, redirect the output of test_commit to stderr. Signed-off-by: Denton Liu --- t/t7700-repack.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/t/t7700-repack.sh b/t/t7700-repack.sh index 4e855bc21b..e1a689d6a9 100755 --- a/t/t7700-repack.sh +++ b/t/t7700-repack.sh @@ -5,7 +5,7 @@ test_description='git repack works correctly' . ./test-lib.sh commit_and_pack() { - test_commit "$@" >/dev/null && + test_commit "$@" 1>&2 && SHA1=$(git pack-objects --all --unpacked --incremental .git/objects/pack/pack /dev/null && + git pack-objects pack && # The second pack will contain the excluded object packsha1=$(git rev-list --objects --all | grep file2 | git pack-objects pack) && @@ -235,7 +235,7 @@ test_expect_success 'incremental repack does not complain' ' test_expect_success 'bitmaps can be disabled on bare repos' ' git -c repack.writeBitmaps=false -C bare.git repack -ad && - bitmap=$(ls bare.git/objects/pack/*.bitmap 2>/dev/null || :) && + bitmap=$(ls bare.git/objects/pack/*.bitmap || :) && test -z "$bitmap" ' -- 2.24.0.504.g3cd56eb17d