From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com> To: git@vger.kernel.org Cc: "Junio C Hamano" <gitster@pobox.com>, "Jeff King" <peff@peff.net>, "Matthieu Moy" <git@matthieu-moy.fr>, "Johannes Schindelin" <Johannes.Schindelin@gmx.de>, "Eric Sunshine" <sunshine@sunshineco.com>, "Đoàn Trần Công Danh" <congdanhqx@gmail.com>, "SZEDER Gábor" <szeder.dev@gmail.com>, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com> Subject: [PATCH v2 00/12] test-lib.sh: new test_commit args, simplification & fixes Date: Sat, 17 Apr 2021 14:52:33 +0200 [thread overview] Message-ID: <cover-00.12-00000000000-20210417T124424Z-avarab@gmail.com> (raw) In-Reply-To: <cover-00.16-00000000000-20210412T110456Z-avarab@gmail.com> This is a "various small fixes" series to test-lib.sh, test-lib-functions.sh. I've addressed the feedback on v1, the "test_create_repo" function is now purely a dumb "git init" wrapper without any arguments, thanks to SZEDER's observation. The trickery with "test" arguments and "$@" later in the series seemed more controversial, so I've peeled those patches off. I'll submit them as another series, I've got various other serieses waiting on the "test_commit" functions here so I'd like to get this in sooner than later, rather than having it hang on the discussion around that. Ævar Arnfjörð Bjarmason (12): check-non-portable-shell: check for "test <cond> -a/-o <cond>" test-lib: bring $remove_trash out of retirement test-lib tests: remove dead GIT_TEST_FRAMEWORK_SELFTEST variable test-lib-functions: reword "test_commit --append" docs test-lib-functions: document test_commit --no-tag test-lib functions: add an --annotated option to "test_commit" describe tests: convert setup to use test_commit test-lib functions: add --printf option to test_commit submodule tests: use symbolic-ref --short to discover branch name test-lib: reformat argument list in test_create_repo() test-lib: do not show advice about init.defaultBranch under --verbose test-lib: split up and deprecate test_create_repo() t/check-non-portable-shell.pl | 2 + t/lib-submodule-update.sh | 3 +- t/t0000-basic.sh | 4 -- t/t1307-config-blob.sh | 4 +- t/t1403-show-ref.sh | 6 +-- t/t2030-unresolve-info.sh | 3 +- t/t4006-diff-mode.sh | 6 +-- t/t4030-diff-textconv.sh | 8 +--- t/t5406-remote-rejects.sh | 1 - t/t5407-post-rewrite-hook.sh | 2 - t/t5409-colorize-remote-messages.sh | 1 - t/t5520-pull.sh | 10 +---- t/t6120-describe.sh | 58 +++++++--------------------- t/test-lib-functions.sh | 60 ++++++++++++++++++----------- t/test-lib.sh | 41 ++++++++++++-------- 15 files changed, 90 insertions(+), 119 deletions(-) Range-diff against v1: 1: 8e4b4a2a216 ! 1: a8b483bc771 check-non-portable-shell: complain about "test" a/-o instead of &&/|| @@ Metadata Author: Ævar Arnfjörð Bjarmason <avarab@gmail.com> ## Commit message ## - check-non-portable-shell: complain about "test" a/-o instead of &&/|| + check-non-portable-shell: check for "test <cond> -a/-o <cond>" - Expand the t/check-non-portable-shell.pl checks to complain about the - use of "-a" and "-o" to the "test" shell built-in to to mean "and" and - "or", as opposed to using two "test" invocations with "&&" or "||". + Add a check for -a/-o in "test", as a follow-up to the + CodingGuidelines having recommended against their use since + 897f964c0dc (CodingGuidelines: avoid "test <cond> -a/-o <cond>", + 2014-05-20). - There aren't any portability issues with using that construct that I - know of, but since Junio expressed a dislike of it in [1] and we've - currently got no such constructs let's add it to the lint checking. I - had various in-flight and WIP patches that used this construct. + These constructs are considered obsolescent by POSIX[1]. GNU has + likewise warned against them[2] for a few decades. - 1. https://lore.kernel.org/git/xmqqa6qkb5fi.fsf@gitster.g/ + These will only match the simplistic forms of `test -X blah` (where + "-X" is some single letter option), but will miss expressions such as + `test "$foo" = bar`. We stop at "&" or "|" to try not to overmatch + things like: + + test whatever && ls -a foo + test whatever && foo -o outfile + + 1. https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html#tag_20_128_16 + 2. https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.70/html_node/Limitations-of-Builtins.html Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> ## t/check-non-portable-shell.pl ## @@ t/check-non-portable-shell.pl: sub err { - next if $line =~ s/\\$//; - - $_ = $line; -+ # Portability issues - /\bcp\s+-a/ and err 'cp -a is not portable'; - /\bsed\s+-[^efn]\s+/ and err 'sed option not portable (use only -n, -e, -f)'; - /\becho\s+-[neE]/ and err 'echo with option is not portable (use printf)'; -@@ t/check-non-portable-shell.pl: sub err { - /\bexport\s+[A-Za-z0-9_]*=/ and err '"export FOO=bar" is not portable (use FOO=bar && export FOO)'; - /^\s*([A-Z0-9_]+=(\w*|(["']).*?\3)\s+)+(\w+)/ and exists($func{$4}) and - err '"FOO=bar shell_func" assignment extends beyond "shell_func"'; -+ # Coding style preferences -+ /\btest\s+-[a-z]\s+.*?\s+-a\s+/ and err '"test A && test B" preferred to "test A -a B"'; -+ /\btest\s+-[a-z]\s+.*?\s+-o\s+/ and err '"test A || test B" preferred to "test A -o B"'; - $line = ''; - # this resets our $. for each file - close ARGV if eof; + /^\s*declare\s+/ and err 'arrays/declare not portable'; + /^\s*[^#]\s*which\s/ and err 'which is not portable (use type)'; + /\btest\s+[^=]*==/ and err '"test a == b" is not portable (use =)'; ++ /\btest\s+-[a-z]\s+[^&|]+\s+-a\s+/ and err '"test A && test B" preferred to "test A -a B"'; ++ /\btest\s+-[a-z]\s+[^&|]+\s+-o\s+/ and err '"test A || test B" preferred to "test A -o B"'; + /\bwc -l.*"\s*=/ and err '`"$(wc -l)"` is not portable (use test_line_count)'; + /\bhead\s+-c\b/ and err 'head -c is not portable (use test_copy_bytes BYTES <file >out)'; + /(?:\$\(seq|^\s*seq\b)/ and err 'seq is not portable (use test_seq)'; 2: 44223ae777e ! 2: 39759d00adf test-lib: bring $remove_trash out of retirement @@ Commit message test-lib: bring $remove_trash out of retirement There's no point in creating a repository or directory only to decide - right afterwards that we're skipping all the tests. + right afterwards that we're skipping all the tests. We can save + ourselves the redundant "git init" or "mkdir" and "rm -rf" in this + case. + + We carry around the "$remove_trash" variable because if the directory + is unexpectedly gone at test_done time we'll hit the error about it + being unexpectedly gone added in df4c0d1a792 (test-lib: abort when + can't remove trash directory, 2017-04-20). So let's partially revert 06478dab4c (test-lib: retire $remove_trash variable, 2017-04-23) and move the decision about whether to skip all 3: 3d04553d710 = 3: d669ce31961 test-lib tests: remove dead GIT_TEST_FRAMEWORK_SELFTEST variable 4: 4ecce153b99 = 4: 9313d35bf86 test-lib-functions: reword "test_commit --append" docs 5: 6df03776940 ! 5: c916d648e49 test-lib-functions: document test_commit --no-tag @@ t/test-lib-functions.sh: debug () { # --author <author> # Invoke "git commit" with --author <author> +# --no-tag -+# Do not tag the resulting commit, if supplied giving the -+# optional "<tag>" argument is an error. ++# Do not tag the resulting commit # # This will commit a file with the given contents and the given commit # message, and tag the resulting commit with the given tag name. 6: 8d43fdd5865 ! 6: 9b6bf65ce1c test-lib functions: add an --annotated-tag option to "test_commit" @@ Metadata Author: Ævar Arnfjörð Bjarmason <avarab@gmail.com> ## Commit message ## - test-lib functions: add an --annotated-tag option to "test_commit" + test-lib functions: add an --annotated option to "test_commit" - Add an --annotated-tag option to test_commit. The tag will share the - same message as the commit, and we'll call test_tick before creating - it (unless --notick) is provided. + Add an --annotated option to test_commit to create annotated tags. The + tag will share the same message as the commit, and we'll call + test_tick before creating it (unless --notick) is provided. There's quite a few tests that could be simplified with this construct. I've picked one to convert in this change as a @@ t/t1403-show-ref.sh: export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME ## t/test-lib-functions.sh ## @@ t/test-lib-functions.sh: debug () { + # Invoke "git commit" with --author <author> # --no-tag - # Do not tag the resulting commit, if supplied giving the - # optional "<tag>" argument is an error. + # Do not tag the resulting commit +# --annotate +# Create an annotated tag with "--annotate -m <message>". Calls -+# test_tick between making the commit and tag unless --notick is -+# given. ++# test_tick between making the commit and tag, unless --notick ++# is given. # # This will commit a file with the given contents and the given commit # message, and tag the resulting commit with the given tag name. @@ t/test-lib-functions.sh: test_commit () { - fi + ;; + annotate) -+ if test "$tag$notick" = "annotate" ++ if test -z "$notick" + then + test_tick + fi && 7: ec4809e7466 = 7: 683b3ba3dd9 describe tests: convert setup to use test_commit 8: 352eeff41c9 = 8: dc0a863db72 test-lib functions: add --printf option to test_commit 9: e7432294215 = 9: 90bf55d2d42 submodule tests: use symbolic-ref --short to discover branch name 10: 634038c3a8d = 10: e0a1e2fd529 test-lib: reformat argument list in test_create_repo() 11: cdbff4df362 = 11: cedf5d383b0 test-lib: do not show advice about init.defaultBranch under --verbose 12: 424caad189f ! 12: a3e20ef18f7 test-lib: modernize test_create_repo() function @@ Metadata Author: Ævar Arnfjörð Bjarmason <avarab@gmail.com> ## Commit message ## - test-lib: modernize test_create_repo() function + test-lib: split up and deprecate test_create_repo() - Remove redundant "mkdir -p", argument number checking', test - environment sanity checking, and disabling of hooks from - test_create_repo(). As we'll see below these were all either redundant - to other test other framework code, or to changes in git itself. + Remove various redundant or obsolete code from the test_create_repo() + function, and split up its use in test-lib.sh from what tests need + from it, leaving us with a pass-through wrapper for "git init" in + test-lib-functions.sh - Respectively: + Reasons for why we can remove various code from test_create_repo(): 1. "mkdir -p" isn't needed because "git init" itself will create leading directories if needed. - 2. We don't need to check the number of arguments anymore, instead - we'll feed "git init" with "$@". It will die if given too many - arguments. + 2. Since we're now a simple wrapper for "git init" we don't need to + check that we have only one argument. If someone wants to run + "test_create_repo --bare x" that's OK. 3. We won't ever hit that "Cannot setup test environment" error. @@ Commit message 5. Since we don't need to move the .git/hooks directory we don't need the subshell here either. + That wasn't really needed for the .git/hooks either, but was being + done for the convenience of not having to quote the path to the + repository as we moved the hooks. + + 6. We can drop the --template argument and instead rely on the + GIT_TEMPLATE_DIR set to the same path earlier in test-lib.sh. See + 8683a45d669 (Introduce GIT_TEMPLATE_DIR, 2006-12-19) + + 7. We only needed that ">&3 2>&4" redirection when invoked from + test-lib.sh, and the same goes for needing the full path to "git". + + Let's move that special behavior into test-lib.sh itself. + In the end it turns out that all we needed was a plain "git init" - invocation with a custom --template directory. + invocation. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> @@ t/t5409-colorize-remote-messages.sh: test_description='remote messages are color ## t/test-lib-functions.sh ## @@ t/test-lib-functions.sh: test_atexit () { - # Most tests can use the created repository, but some may need to create more. + } && (exit \"\$eval_ret\"); eval_ret=\$?; $test_atexit_cleanup" + } + +-# Most tests can use the created repository, but some may need to create more. ++# Deprecated wrapper for "git init", use "git init" directly instead # Usage: test_create_repo <directory> test_create_repo () { - test "$#" = 1 || @@ t/test-lib-functions.sh: test_atexit () { - error "cannot run git init -- have you built things yet?" - mv .git/hooks .git/hooks-disabled - ) || exit -+ "${GIT_TEST_INSTALLED:-$GIT_EXEC_PATH}/git$X" \ -+ init \ -+ "--template=$GIT_BUILD_DIR/templates/blt/" "$@" >&3 2>&4 ++ git init "$@" } # This function helps on symlink challenged file systems when it is not + + ## t/test-lib.sh ## +@@ t/test-lib.sh: rm -fr "$TRASH_DIRECTORY" || { + remove_trash=t + if test -z "$TEST_NO_CREATE_REPO" + then +- test_create_repo "$TRASH_DIRECTORY" ++ "${GIT_TEST_INSTALLED:-$GIT_BUILD_DIR}/git$X" \ ++ init \ ++ "$TRASH_DIRECTORY" >&3 2>&4 || ++ error "cannot run git init" + else + mkdir -p "$TRASH_DIRECTORY" + fi 13: 0813aa8e34e < -: ----------- test-lib-functions: normalize test_path_is_missing() debugging 14: b6e9d971b40 < -: ----------- test-lib-functions: use "return 1" instead of "false" 15: 0cd511206c4 < -: ----------- Revert and amend "test-lib-functions: assert correct parameter count" 16: b4a018a63f3 < -: ----------- test-lib-functions: remove last two parameter count assertions -- 2.31.1.722.g788886f50a2
next prev parent reply other threads:[~2021-04-17 12:53 UTC|newest] Thread overview: 175+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-12 11:08 [PATCH 00/16] " Ævar Arnfjörð Bjarmason 2021-04-12 11:08 ` [PATCH 01/16] check-non-portable-shell: complain about "test" a/-o instead of &&/|| Ævar Arnfjörð Bjarmason 2021-04-12 17:00 ` Eric Sunshine 2021-04-12 17:13 ` Matthieu Moy 2021-04-12 18:36 ` Junio C Hamano 2021-04-12 18:38 ` Junio C Hamano 2021-04-12 18:48 ` Eric Sunshine 2021-04-12 11:08 ` [PATCH 02/16] test-lib: bring $remove_trash out of retirement Ævar Arnfjörð Bjarmason 2021-04-12 19:06 ` Junio C Hamano 2021-04-12 21:22 ` Junio C Hamano 2021-04-12 11:08 ` [PATCH 03/16] test-lib tests: remove dead GIT_TEST_FRAMEWORK_SELFTEST variable Ævar Arnfjörð Bjarmason 2021-04-12 11:08 ` [PATCH 04/16] test-lib-functions: reword "test_commit --append" docs Ævar Arnfjörð Bjarmason 2021-04-12 11:08 ` [PATCH 05/16] test-lib-functions: document test_commit --no-tag Ævar Arnfjörð Bjarmason 2021-04-12 17:07 ` Eric Sunshine 2021-04-12 11:08 ` [PATCH 06/16] test-lib functions: add an --annotated-tag option to "test_commit" Ævar Arnfjörð Bjarmason 2021-04-15 15:33 ` Đoàn Trần Công Danh 2021-04-12 11:08 ` [PATCH 07/16] describe tests: convert setup to use test_commit Ævar Arnfjörð Bjarmason 2021-04-12 11:08 ` [PATCH 08/16] test-lib functions: add --printf option to test_commit Ævar Arnfjörð Bjarmason 2021-04-12 19:05 ` Eric Sunshine 2021-04-12 21:27 ` Junio C Hamano 2021-04-12 23:04 ` Eric Sunshine 2021-04-12 23:12 ` Junio C Hamano 2021-04-15 11:33 ` Ævar Arnfjörð Bjarmason 2021-04-15 14:52 ` Eric Sunshine 2021-04-15 18:37 ` Junio C Hamano 2021-04-12 11:08 ` [PATCH 09/16] submodule tests: use symbolic-ref --short to discover branch name Ævar Arnfjörð Bjarmason 2021-04-12 11:08 ` [PATCH 10/16] test-lib: reformat argument list in test_create_repo() Ævar Arnfjörð Bjarmason 2021-04-12 11:09 ` [PATCH 11/16] test-lib: do not show advice about init.defaultBranch under --verbose Ævar Arnfjörð Bjarmason 2021-04-15 19:07 ` SZEDER Gábor 2021-04-12 11:09 ` [PATCH 12/16] test-lib: modernize test_create_repo() function Ævar Arnfjörð Bjarmason 2021-04-12 19:27 ` Junio C Hamano 2021-04-15 11:40 ` Ævar Arnfjörð Bjarmason 2021-04-15 21:10 ` SZEDER Gábor 2021-04-16 21:22 ` SZEDER Gábor 2021-04-16 23:38 ` Ævar Arnfjörð Bjarmason 2021-04-12 11:09 ` [PATCH 13/16] test-lib-functions: normalize test_path_is_missing() debugging Ævar Arnfjörð Bjarmason 2021-04-12 11:09 ` [PATCH 14/16] test-lib-functions: use "return 1" instead of "false" Ævar Arnfjörð Bjarmason 2021-04-12 19:31 ` Junio C Hamano 2021-04-12 11:09 ` [PATCH 15/16] Revert and amend "test-lib-functions: assert correct parameter count" Ævar Arnfjörð Bjarmason 2021-04-12 19:37 ` Junio C Hamano 2021-04-15 11:32 ` Ævar Arnfjörð Bjarmason 2021-04-15 12:31 ` Andreas Schwab 2021-04-15 18:35 ` Junio C Hamano 2021-04-16 21:06 ` Ævar Arnfjörð Bjarmason 2021-04-15 22:05 ` SZEDER Gábor 2021-04-15 22:24 ` Junio C Hamano 2021-04-16 23:48 ` Ævar Arnfjörð Bjarmason 2021-04-12 11:09 ` [PATCH 16/16] test-lib-functions: remove last two parameter count assertions Ævar Arnfjörð Bjarmason 2021-04-12 19:40 ` Junio C Hamano 2021-04-12 18:18 ` [PATCH 00/16] test-lib.sh: new test_commit args, simplification & fixes Junio C Hamano 2021-04-17 12:52 ` Ævar Arnfjörð Bjarmason [this message] 2021-04-17 12:52 ` [PATCH v2 01/12] check-non-portable-shell: check for "test <cond> -a/-o <cond>" Ævar Arnfjörð Bjarmason 2021-04-17 12:52 ` [PATCH v2 02/12] test-lib: bring $remove_trash out of retirement Ævar Arnfjörð Bjarmason 2021-04-17 12:52 ` [PATCH v2 03/12] test-lib tests: remove dead GIT_TEST_FRAMEWORK_SELFTEST variable Ævar Arnfjörð Bjarmason 2021-04-17 12:52 ` [PATCH v2 04/12] test-lib-functions: reword "test_commit --append" docs Ævar Arnfjörð Bjarmason 2021-04-17 12:52 ` [PATCH v2 05/12] test-lib-functions: document test_commit --no-tag Ævar Arnfjörð Bjarmason 2021-04-17 12:52 ` [PATCH v2 06/12] test-lib functions: add an --annotated option to "test_commit" Ævar Arnfjörð Bjarmason 2021-04-17 12:52 ` [PATCH v2 07/12] describe tests: convert setup to use test_commit Ævar Arnfjörð Bjarmason 2021-04-17 12:52 ` [PATCH v2 08/12] test-lib functions: add --printf option to test_commit Ævar Arnfjörð Bjarmason 2021-04-17 12:52 ` [PATCH v2 09/12] submodule tests: use symbolic-ref --short to discover branch name Ævar Arnfjörð Bjarmason 2021-04-17 12:52 ` [PATCH v2 10/12] test-lib: reformat argument list in test_create_repo() Ævar Arnfjörð Bjarmason 2021-04-17 12:52 ` [PATCH v2 11/12] test-lib: do not show advice about init.defaultBranch under --verbose Ævar Arnfjörð Bjarmason 2021-04-17 12:52 ` [PATCH v2 12/12] test-lib: split up and deprecate test_create_repo() Ævar Arnfjörð Bjarmason 2021-04-17 15:42 ` SZEDER Gábor 2021-04-17 21:45 ` Ævar Arnfjörð Bjarmason 2021-04-20 21:27 ` SZEDER Gábor 2021-04-17 12:58 ` [PATCH 0/3] test-lib-functions.sh: trickery to make -x less verbose Ævar Arnfjörð Bjarmason 2021-04-17 12:58 ` [PATCH 1/3] test-lib-functions: normalize test_path_is_missing() debugging Ævar Arnfjörð Bjarmason 2021-04-17 12:58 ` [PATCH 2/3] Revert and amend "test-lib-functions: assert correct parameter count" Ævar Arnfjörð Bjarmason 2021-04-18 5:11 ` Eric Sunshine 2021-04-20 12:25 ` Ævar Arnfjörð Bjarmason 2021-04-17 12:58 ` [PATCH 3/3] test-lib-functions: remove last two parameter count assertions Ævar Arnfjörð Bjarmason 2021-04-20 12:21 ` [PATCH v3 00/12] test-lib.sh: new test_commit args, simplification & fixes Ævar Arnfjörð Bjarmason 2021-04-20 12:21 ` [PATCH v3 01/12] check-non-portable-shell: check for "test <cond> -a/-o <cond>" Ævar Arnfjörð Bjarmason 2021-04-20 22:25 ` Junio C Hamano 2021-04-21 8:46 ` Ævar Arnfjörð Bjarmason 2021-04-21 10:39 ` Đoàn Trần Công Danh 2021-04-21 10:41 ` [PATCH 1/2] t6400: check exit status of ls-files Đoàn Trần Công Danh 2021-04-21 10:41 ` [PATCH 2/2] t6402: " Đoàn Trần Công Danh 2021-04-21 16:55 ` Eric Sunshine 2021-04-21 17:32 ` Eric Sunshine 2021-04-21 23:32 ` Junio C Hamano 2021-04-22 13:49 ` Đoàn Trần Công Danh 2021-04-22 15:04 ` Ævar Arnfjörð Bjarmason 2021-04-22 15:30 ` Eric Sunshine 2021-04-22 15:07 ` Đoàn Trần Công Danh 2021-04-22 12:45 ` Ævar Arnfjörð Bjarmason 2021-04-21 14:18 ` [PATCH v3 01/12] check-non-portable-shell: check for "test <cond> -a/-o <cond>" Ævar Arnfjörð Bjarmason 2021-04-21 16:32 ` Junio C Hamano 2021-04-21 18:56 ` Junio C Hamano 2021-04-20 12:21 ` [PATCH v3 02/12] test-lib: bring $remove_trash out of retirement Ævar Arnfjörð Bjarmason 2021-04-20 22:28 ` Junio C Hamano 2021-04-20 12:21 ` [PATCH v3 03/12] test-lib tests: remove dead GIT_TEST_FRAMEWORK_SELFTEST variable Ævar Arnfjörð Bjarmason 2021-04-20 12:21 ` [PATCH v3 04/12] test-lib-functions: reword "test_commit --append" docs Ævar Arnfjörð Bjarmason 2021-04-20 12:21 ` [PATCH v3 05/12] test-lib-functions: document test_commit --no-tag Ævar Arnfjörð Bjarmason 2021-04-20 12:21 ` [PATCH v3 06/12] test-lib functions: add an --annotated option to "test_commit" Ævar Arnfjörð Bjarmason 2021-04-20 12:21 ` [PATCH v3 07/12] describe tests: convert setup to use test_commit Ævar Arnfjörð Bjarmason 2021-04-20 12:21 ` [PATCH v3 08/12] test-lib functions: add --printf option to test_commit Ævar Arnfjörð Bjarmason 2021-04-20 12:22 ` [PATCH v3 09/12] submodule tests: use symbolic-ref --short to discover branch name Ævar Arnfjörð Bjarmason 2021-04-20 12:22 ` [PATCH v3 10/12] test-lib: reformat argument list in test_create_repo() Ævar Arnfjörð Bjarmason 2021-04-20 12:22 ` [PATCH v3 11/12] test-lib: do not show advice about init.defaultBranch under --verbose Ævar Arnfjörð Bjarmason 2021-04-20 12:22 ` [PATCH v3 12/12] test-lib: split up and deprecate test_create_repo() Ævar Arnfjörð Bjarmason 2021-04-21 10:15 ` [PATCH v4 00/11] test-lib.sh: new test_commit args, simplification & fixes Ævar Arnfjörð Bjarmason 2021-04-21 10:15 ` [PATCH v4 01/11] test-lib: bring $remove_trash out of retirement Ævar Arnfjörð Bjarmason 2021-04-21 10:15 ` [PATCH v4 02/11] test-lib tests: remove dead GIT_TEST_FRAMEWORK_SELFTEST variable Ævar Arnfjörð Bjarmason 2021-04-21 10:15 ` [PATCH v4 03/11] test-lib-functions: reword "test_commit --append" docs Ævar Arnfjörð Bjarmason 2021-04-21 10:15 ` [PATCH v4 04/11] test-lib-functions: document test_commit --no-tag Ævar Arnfjörð Bjarmason 2021-04-21 10:15 ` [PATCH v4 05/11] test-lib functions: add an --annotated option to "test_commit" Ævar Arnfjörð Bjarmason 2021-04-21 10:15 ` [PATCH v4 06/11] describe tests: convert setup to use test_commit Ævar Arnfjörð Bjarmason 2021-04-21 10:15 ` [PATCH v4 07/11] test-lib functions: add --printf option to test_commit Ævar Arnfjörð Bjarmason 2021-04-21 10:15 ` [PATCH v4 08/11] submodule tests: use symbolic-ref --short to discover branch name Ævar Arnfjörð Bjarmason 2021-04-21 10:15 ` [PATCH v4 09/11] test-lib: reformat argument list in test_create_repo() Ævar Arnfjörð Bjarmason 2021-04-21 10:15 ` [PATCH v4 10/11] test-lib: do not show advice about init.defaultBranch under --verbose Ævar Arnfjörð Bjarmason 2021-04-21 10:15 ` [PATCH v4 11/11] test-lib: split up and deprecate test_create_repo() Ævar Arnfjörð Bjarmason 2021-04-21 16:43 ` SZEDER Gábor 2021-04-22 12:39 ` Ævar Arnfjörð Bjarmason 2021-04-23 7:21 ` [PATCH v5 00/11] test-lib.sh: new test_commit args, simplification & fixes Ævar Arnfjörð Bjarmason 2021-04-23 7:21 ` [PATCH v5 01/11] test-lib: bring $remove_trash out of retirement Ævar Arnfjörð Bjarmason 2021-05-06 15:46 ` Đoàn Trần Công Danh 2021-04-23 7:21 ` [PATCH v5 02/11] test-lib tests: remove dead GIT_TEST_FRAMEWORK_SELFTEST variable Ævar Arnfjörð Bjarmason 2021-04-23 7:21 ` [PATCH v5 03/11] test-lib-functions: reword "test_commit --append" docs Ævar Arnfjörð Bjarmason 2021-04-23 7:21 ` [PATCH v5 04/11] test-lib-functions: document test_commit --no-tag Ævar Arnfjörð Bjarmason 2021-04-23 7:21 ` [PATCH v5 05/11] test-lib functions: add an --annotated option to "test_commit" Ævar Arnfjörð Bjarmason 2021-04-23 7:21 ` [PATCH v5 06/11] describe tests: convert setup to use test_commit Ævar Arnfjörð Bjarmason 2021-05-06 15:58 ` Đoàn Trần Công Danh 2021-04-23 7:21 ` [PATCH v5 07/11] test-lib functions: add --printf option to test_commit Ævar Arnfjörð Bjarmason 2021-05-06 16:08 ` Đoàn Trần Công Danh 2021-04-23 7:21 ` [PATCH v5 08/11] submodule tests: use symbolic-ref --short to discover branch name Ævar Arnfjörð Bjarmason 2021-04-23 7:21 ` [PATCH v5 09/11] test-lib: reformat argument list in test_create_repo() Ævar Arnfjörð Bjarmason 2021-04-23 7:21 ` [PATCH v5 10/11] test-lib: do not show advice about init.defaultBranch under --verbose Ævar Arnfjörð Bjarmason 2021-04-23 7:21 ` [PATCH v5 11/11] test-lib: split up and deprecate test_create_repo() Ævar Arnfjörð Bjarmason 2021-04-29 7:23 ` [PATCH v5 00/11] test-lib.sh: new test_commit args, simplification & fixes Junio C Hamano 2021-05-06 15:32 ` Ævar Arnfjörð Bjarmason 2021-05-06 16:21 ` Đoàn Trần Công Danh 2021-05-10 14:18 ` [PATCH v6 " Ævar Arnfjörð Bjarmason 2021-05-10 14:19 ` [PATCH v6 01/11] test-lib: bring $remove_trash out of retirement Ævar Arnfjörð Bjarmason 2021-05-10 14:19 ` [PATCH v6 02/11] test-lib tests: remove dead GIT_TEST_FRAMEWORK_SELFTEST variable Ævar Arnfjörð Bjarmason 2021-05-10 14:19 ` [PATCH v6 03/11] test-lib-functions: reword "test_commit --append" docs Ævar Arnfjörð Bjarmason 2021-05-10 14:19 ` [PATCH v6 04/11] test-lib-functions: document test_commit --no-tag Ævar Arnfjörð Bjarmason 2021-05-10 14:19 ` [PATCH v6 05/11] test-lib functions: add an --annotated option to "test_commit" Ævar Arnfjörð Bjarmason 2021-05-10 14:19 ` [PATCH v6 06/11] describe tests: convert setup to use test_commit Ævar Arnfjörð Bjarmason 2021-05-10 14:19 ` [PATCH v6 07/11] test-lib functions: add --printf option to test_commit Ævar Arnfjörð Bjarmason 2021-05-10 14:19 ` [PATCH v6 08/11] submodule tests: use symbolic-ref --short to discover branch name Ævar Arnfjörð Bjarmason 2021-05-10 14:19 ` [PATCH v6 09/11] test-lib: reformat argument list in test_create_repo() Ævar Arnfjörð Bjarmason 2021-05-10 14:19 ` [PATCH v6 10/11] test-lib: do not show advice about init.defaultBranch under --verbose Ævar Arnfjörð Bjarmason 2021-05-10 14:19 ` [PATCH v6 11/11] test-lib: split up and deprecate test_create_repo() Ævar Arnfjörð Bjarmason 2021-05-13 6:45 ` Felipe Contreras 2021-05-13 7:45 ` Ævar Arnfjörð Bjarmason 2021-05-13 8:23 ` Felipe Contreras 2021-05-13 12:05 ` Ævar Arnfjörð Bjarmason 2021-05-13 20:11 ` Felipe Contreras 2021-05-12 12:19 ` [PATCH v6 00/11] test-lib.sh: new test_commit args, simplification & fixes Đoàn Trần Công Danh 2021-05-12 23:24 ` Junio C Hamano 2021-04-20 12:29 ` [PATCH v2 0/3] test-lib-functions.sh: trickery to make -x less verbose Ævar Arnfjörð Bjarmason 2021-04-20 12:29 ` [PATCH v2 1/3] test-lib-functions: normalize test_path_is_missing() debugging Ævar Arnfjörð Bjarmason 2021-04-20 12:29 ` [PATCH v2 2/3] Revert and amend "test-lib-functions: assert correct parameter count" Ævar Arnfjörð Bjarmason 2021-04-20 15:07 ` Eric Sunshine 2021-04-21 8:22 ` Ævar Arnfjörð Bjarmason 2021-04-20 12:29 ` [PATCH v2 3/3] test-lib-functions: remove last two parameter count assertions Ævar Arnfjörð Bjarmason 2021-04-20 21:15 ` Junio C Hamano 2021-04-21 14:58 ` [PATCH v2 0/5] test-lib-functions.sh: trickery to make -x less verbose Ævar Arnfjörð Bjarmason 2021-04-21 14:58 ` [PATCH v2 1/5] test-lib-functions: normalize test_path_is_missing() debugging Ævar Arnfjörð Bjarmason 2021-04-21 14:58 ` [PATCH v2 2/5] Revert and amend "test-lib-functions: assert correct parameter count" Ævar Arnfjörð Bjarmason 2021-04-21 14:58 ` [PATCH v2 3/5] test helpers: remove unused test-tool path-utils slice-tests Ævar Arnfjörð Bjarmason 2021-04-21 18:02 ` Ævar Arnfjörð Bjarmason 2021-04-21 14:58 ` [PATCH v2 4/5] test-helpers: rename "path-utils is_valid_path" to "is-valid-paths" Ævar Arnfjörð Bjarmason 2021-04-21 14:58 ` [PATCH v2 5/5] test-helpers: split "file-size" into "file-size(s)" Ævar Arnfjörð Bjarmason 2021-04-23 7:29 ` [PATCH v3 0/4] test-lib-functions.sh: trickery to make -x less verbose Ævar Arnfjörð Bjarmason 2021-04-23 7:29 ` [PATCH v3 1/4] test-lib-functions: normalize test_path_is_missing() debugging Ævar Arnfjörð Bjarmason 2021-04-29 3:49 ` Junio C Hamano 2021-04-23 7:29 ` [PATCH v3 2/4] Revert and amend "test-lib-functions: assert correct parameter count" Ævar Arnfjörð Bjarmason 2021-04-29 3:59 ` Junio C Hamano 2021-04-29 4:02 ` Felipe Contreras 2021-04-23 7:29 ` [PATCH v3 3/4] test-helpers: rename "path-utils is_valid_path" to "is-valid-paths" Ævar Arnfjörð Bjarmason 2021-04-23 7:29 ` [PATCH v3 4/4] test-helpers: split "file-size" into "file-size(s)" Ævar Arnfjörð Bjarmason
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover-00.12-00000000000-20210417T124424Z-avarab@gmail.com \ --to=avarab@gmail.com \ --cc=Johannes.Schindelin@gmx.de \ --cc=congdanhqx@gmail.com \ --cc=git@matthieu-moy.fr \ --cc=git@vger.kernel.org \ --cc=gitster@pobox.com \ --cc=peff@peff.net \ --cc=sunshine@sunshineco.com \ --cc=szeder.dev@gmail.com \ --subject='Re: [PATCH v2 00/12] test-lib.sh: new test_commit args, simplification & fixes' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).