From: Jonathan Tan <jonathantanmy@google.com>
To: git@vger.kernel.org
Cc: Jonathan Tan <jonathantanmy@google.com>,
peff@peff.net, gitster@pobox.com
Subject: [PATCH v2 0/2] Repacking of promisor packfiles
Date: Wed, 8 Aug 2018 15:34:04 -0700 [thread overview]
Message-ID: <cover.1533767314.git.jonathantanmy@google.com> (raw)
In-Reply-To: <cover.1533672584.git.jonathantanmy@google.com>
Changes from v1:
- add NEEDSWORK stating that input to pack-objects could be removed
- run pack-objects to repack promisor objects only if there is at least
one of them - this exposed a possible bug where the later part of
cmd_repack() requires a correct packed_git (this was mostly noticed
by tests that deal with corrupt packfiles), so insert a call to
reprepare_packed_git() after all packfile manipulation is done
- rename prepare_packed_objects() to prepare_pack_objects() to better
reflect that we are preparing a call to pack-objects, not preparing
existing packed objects
Peff raised the possibility of making for_each_packed_object() use pack
order instead of index order - I'll also take a look at that, separately
from this patch series.
Jonathan Tan (2):
repack: refactor setup of pack-objects cmd
repack: repack promisor objects if -a or -A is set
Documentation/git-repack.txt | 5 +
builtin/repack.c | 182 ++++++++++++++++++++++++++---------
t/t0410-partial-clone.sh | 85 +++++++++++++---
3 files changed, 213 insertions(+), 59 deletions(-)
--
2.18.0.597.ga71716f1ad-goog
next prev parent reply other threads:[~2018-08-08 22:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 20:12 [PATCH 0/2] Repacking of promisor packfiles Jonathan Tan
2018-08-07 20:12 ` [PATCH 1/2] repack: refactor setup of pack-objects cmd Jonathan Tan
2018-08-07 20:12 ` [PATCH 2/2] repack: repack promisor objects if -a or -A is set Jonathan Tan
2018-08-07 20:57 ` Junio C Hamano
2018-08-07 23:23 ` Jonathan Tan
2018-08-08 0:25 ` Junio C Hamano
2018-08-08 18:45 ` Jonathan Tan
2018-08-08 15:50 ` Jeff King
2018-08-08 16:17 ` Junio C Hamano
2018-08-07 22:37 ` Junio C Hamano
2018-08-07 23:25 ` Jonathan Tan
2018-08-08 16:34 ` Junio C Hamano
2018-08-08 22:34 ` Jonathan Tan [this message]
2018-08-08 22:34 ` [PATCH v2 1/2] repack: refactor setup of pack-objects cmd Jonathan Tan
2018-08-08 22:34 ` [PATCH v2 2/2] repack: repack promisor objects if -a or -A is set Jonathan Tan
2018-08-09 17:05 ` Junio C Hamano
2018-08-09 18:12 ` Jonathan Tan
2018-08-18 16:05 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1533767314.git.jonathantanmy@google.com \
--to=jonathantanmy@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).