git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: git@vger.kernel.org
Cc: jonathantanmy@google.com, gitster@pobox.com, newren@gmail.com
Subject: [PATCH v2 0/2] shallow.c: reset shallow-ness after updating
Date: Wed, 22 Apr 2020 18:25:36 -0600	[thread overview]
Message-ID: <cover.1587601501.git.me@ttaylorr.com> (raw)
In-Reply-To: <20200423001438.GC19100@syl.local>

Hi,

Here is an updated version of the patch that I sent above (which was
itself an updated version of a patch that I sent to some other
sub-thread...).

In this version, I added an extra patch at the beginning to clean up
some surrounding tests in t5537 so the new ones are added both in a good
style, and in a way that is consistent with the surrounding code.

I also adopted a suggestion from Junio that introduces
'{commit,rollback}_shallow_file()' as thin wrappers around
'{commit,rollback}_lock_file()', which makes this whole thing a lot
tidier.

Thanks in advance for another look...

Taylor Blau (2):
  t5537: use test_write_lines, indented heredocs for readability
  shallow.c: use '{commit,rollback}_shallow_file'

 builtin/receive-pack.c   |  4 +-
 commit.h                 |  2 +
 fetch-pack.c             | 10 ++--
 shallow.c                | 30 ++++++++----
 t/t5537-fetch-shallow.sh | 99 +++++++++++++++++++---------------------
 5 files changed, 77 insertions(+), 68 deletions(-)

--
2.26.0.113.ge9739cdccc

  reply	other threads:[~2020-04-23  0:25 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-21 18:09 [PATCH] shallow.c: use 'reset_repository_shallow' when appropriate Taylor Blau
2020-04-21 20:41 ` Junio C Hamano
2020-04-21 20:45   ` Taylor Blau
2020-04-21 20:52     ` Junio C Hamano
2020-04-21 22:21       ` Taylor Blau
2020-04-21 23:06         ` Junio C Hamano
2020-04-22 18:05       ` Jonathan Tan
2020-04-22 18:02 ` Jonathan Tan
2020-04-22 18:15   ` Junio C Hamano
2020-04-23  0:14     ` Taylor Blau
2020-04-23  0:25       ` Taylor Blau [this message]
2020-04-23  0:25         ` [PATCH v2 1/2] t5537: use test_write_lines, indented heredocs for readability Taylor Blau
2020-04-23  1:14           ` Jonathan Nieder
2020-04-24 17:11             ` Taylor Blau
2020-04-24 17:17               ` Jonathan Nieder
2020-04-24 20:45               ` Junio C Hamano
2020-04-23  0:25         ` [PATCH v2 2/2] shallow.c: use '{commit,rollback}_shallow_file' Taylor Blau
2020-04-23  1:23           ` Jonathan Nieder
2020-04-23 18:09           ` Jonathan Tan
2020-04-23 20:40             ` Junio C Hamano
2020-04-24 17:13               ` Taylor Blau
2020-06-03  3:42           ` Jonathan Nieder
2020-06-03  4:52             ` Taylor Blau
2020-06-03  5:16               ` Taylor Blau
2020-06-03 13:08                 ` Derrick Stolee
2020-06-03 19:26                   ` Taylor Blau
2020-06-03 21:23                   ` Jonathan Nieder
2020-06-03 20:51                 ` Jonathan Nieder
2020-06-03 22:14                   ` Taylor Blau
2020-06-03 23:06                     ` Jonathan Nieder
2020-06-04 17:45                       ` Taylor Blau
2020-04-23 19:05       ` [PATCH] shallow.c: use 'reset_repository_shallow' when appropriate Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1587601501.git.me@ttaylorr.com \
    --to=me@ttaylorr.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jonathantanmy@google.com \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).