Git Mailing List Archive on lore.kernel.org
 help / color / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: git@vger.kernel.org
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Jeff King" <peff@peff.net>
Subject: [PATCH 0/2] git: support separate arg for `--config-env`'s value
Date: Mon, 19 Apr 2021 17:56:45 +0200
Message-ID: <cover.1618847606.git.ps@pks.im> (raw)


[-- Attachment #1: Type: text/plain, Size: 855 bytes --]

Hi,

As pointed out by Ævar, the synopsis in the git(1) manpage was
misdocumenting the syntax of the `--config-env` option. This patch
series fixes it and also addresses the shortcoming that while most of
the other options support both `--git-dir=foo` and `--git-dir foo`,
`--config-env` only supported the former format.

I'm happy to drop the latter patch if it's generally seen as something
that's not needed, but Ævar and Peff got a point in that it feels
inconsistent with the other options.

Patrick

Patrick Steinhardt (2):
  git.txt: fix synopsis of `--config-env` missing the equals sign
  git: support separate arg for `--config-env`'s value

 Documentation/git.txt |  2 +-
 git.c                 |  8 ++++++++
 t/t1300-config.sh     | 15 ++++++++++++++-
 3 files changed, 23 insertions(+), 2 deletions(-)

-- 
2.31.1


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

             reply index

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-19 15:56 Patrick Steinhardt [this message]
2021-04-19 15:56 ` [PATCH 1/2] git.txt: fix synopsis of `--config-env` missing the equals sign Patrick Steinhardt
2021-04-19 15:56 ` [PATCH 2/2] git: support separate arg for `--config-env`'s value Patrick Steinhardt
2021-04-20 10:52   ` Ævar Arnfjörð Bjarmason
2021-04-23 10:07     ` Jeff King
2021-04-20 11:24   ` Ævar Arnfjörð Bjarmason
2021-04-29 12:55 ` [PATCH v2 0/2] " Patrick Steinhardt
2021-04-29 12:55   ` [PATCH v2 1/2] git.txt: fix synopsis of `--config-env` missing the equals sign Patrick Steinhardt
2021-04-29 12:55   ` [PATCH v2 2/2] git: support separate arg for `--config-env`'s value Patrick Steinhardt
2021-04-29 20:04   ` [PATCH v2 0/2] " Jeff King
2021-04-30  0:47     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1618847606.git.ps@pks.im \
    --to=ps@pks.im \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Mailing List Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/git/0 git/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 git git/ https://lore.kernel.org/git \
		git@vger.kernel.org
	public-inbox-index git

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.git


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git