From: Ramsay Jones <ramsay@ramsayjones.plus.com>
To: Han-Wen Nienhuys <hanwen@google.com>
Cc: GIT Mailing-list <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] reftable: fix some sparse warnings
Date: Wed, 30 Sep 2020 21:18:14 +0100 [thread overview]
Message-ID: <d3c6bd3d-9f1c-00e3-fa31-67ad0d45fdbf@ramsayjones.plus.com> (raw)
In-Reply-To: <CAFQ2z_PNT0g2yAbMkWEQW3UjbMbzALfkAfLDzpiUZjOE0b29vw@mail.gmail.com>
On 30/09/2020 17:51, Han-Wen Nienhuys wrote:
> On Wed, Sep 23, 2020 at 12:47 AM Ramsay Jones
> <ramsay@ramsayjones.plus.com> wrote:
>> If you need to re-roll your 'hn/reftable' branch, could you please squash this
>> into the relevant patches.
>>
>
> Thanks for the heads-up. I fixed some of these issues in the source at
> google/reftable. I've seen a Helped-By footer used to acknowledge
> these types of contributions, but I'm not sure on which of the 13
> commits I should put that; suggestions?
I will leave you to decide, but I didn't actually do much (sparse
did most of the heavy lifting)! ;-)
>
>> This patch is based on top of 'seen' and removes 20 sparse warnings (19 of the
>
> Could you tell me how I can run these checks myself?
$ make sparse
You will need to install a suitably new version of sparse, of course.
I believe (but don't quote me) that debian testing has a suitable
version based on the 'maint-v0.6.2' branch. ('git describe maint-v0.6.2'
shows that it has four commits on top of the last official release
version: v0.6.2-4-gb47eba20). Having said that, v0.6.2 should also be
fine (I build from source, so have version v0.6.2-201-g24bdaac6).
[for more sparse info, see: https://sparse.docs.kernel.org]
>
>> Just for your information, you may want to look at the following 27 symbols:
>
>> > reftable/merged.o - reftable_merged_table_hash_id
>> > reftable/merged.o - reftable_merged_table_max_update_index
>> > reftable/merged.o - reftable_merged_table_min_update_index
>> > reftable/merged.o - reftable_merged_table_seek_log_at
>> > reftable/publicbasics.o - reftable_error_to_errno
>> > reftable/publicbasics.o - reftable_set_alloc
>> > reftable/reader.o - reftable_reader_seek_log_at
>> > reftable/stack.o - reftable_addition_close
>> > reftable/stack.o - reftable_stack_auto_compact
>
> These functions are part of the public API. We'll need to get the
> reftable glue code into seen. Perhaps some need unittest coverage too.
So, do I take it that the other 18 symbols are now marked 'static'?
[you would need 'static-check.pl' to catch symbols like the above].
ATB,
Ramsay Jones
prev parent reply other threads:[~2020-09-30 20:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 22:47 [PATCH] reftable: fix some sparse warnings Ramsay Jones
2020-09-30 16:51 ` Han-Wen Nienhuys
2020-09-30 20:18 ` Ramsay Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3c6bd3d-9f1c-00e3-fa31-67ad0d45fdbf@ramsayjones.plus.com \
--to=ramsay@ramsayjones.plus.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hanwen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).