From: "Jeff Hostetler via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Jeff Hostetler <jeffhost@microsoft.com>,
Jeff Hostetler <jeffhost@microsoft.com>
Subject: [PATCH 2/2] builtin/unpack-objects.c: fix compiler error on MacOS with clang 11.0.0
Date: Thu, 06 Oct 2022 19:43:15 +0000 [thread overview]
Message-ID: <e5009a325f234eef7e80335e458fbe11a2ccf5f4.1665085395.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1375.git.1665085395.gitgitgadget@gmail.com>
From: Jeff Hostetler <jeffhost@microsoft.com>
Add an extra set of braces around zero initialization of the `zstream`
variable to resolve compiler error/warning from clang 11.0.0 on MacOS.
This is not needed on clang 14.0.
$ make builtin/unpack-objects.o
CC builtin/unpack-objects.o
builtin/unpack-objects.c:388:26: error: suggest braces around \
initialization of subobject [-Werror,-Wmissing-braces]
git_zstream zstream = { 0 };
^
{}
1 error generated.
make: *** [builtin/unpack-objects.o] Error 1
Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
---
builtin/unpack-objects.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/unpack-objects.c b/builtin/unpack-objects.c
index 43789b8ef29..4b16f1592ba 100644
--- a/builtin/unpack-objects.c
+++ b/builtin/unpack-objects.c
@@ -385,7 +385,7 @@ static const void *feed_input_zstream(struct input_stream *in_stream,
static void stream_blob(unsigned long size, unsigned nr)
{
- git_zstream zstream = { 0 };
+ git_zstream zstream = { { 0 } };
struct input_zstream_data data = { 0 };
struct input_stream in_stream = {
.read = feed_input_zstream,
--
gitgitgadget
next prev parent reply other threads:[~2022-10-06 19:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 19:43 [PATCH 0/2] Fix syntax errors under clang 11.0.0 on MacOS Jeff Hostetler via GitGitGadget
2022-10-06 19:43 ` [PATCH 1/2] builtin/merge-file: fix compiler error on MacOS with clang 11.0.0 Jeff Hostetler via GitGitGadget
2022-10-06 21:09 ` René Scharfe
2022-10-06 22:30 ` Eric Sunshine
2022-10-06 22:51 ` Junio C Hamano
2022-10-06 19:43 ` Jeff Hostetler via GitGitGadget [this message]
2022-10-06 20:38 ` [PATCH 0/2] Fix syntax errors under clang 11.0.0 on MacOS Junio C Hamano
2022-10-06 20:58 ` Eric Sunshine
2022-10-07 11:02 ` Ævar Arnfjörð Bjarmason
2022-10-07 15:19 ` Jeff Hostetler
2022-10-07 17:49 ` Junio C Hamano
2022-10-07 20:28 ` René Scharfe
2022-10-07 20:56 ` Jeff Hostetler
2022-10-07 21:33 ` Junio C Hamano
2022-10-08 3:46 ` Eric Sunshine
2022-10-08 6:52 ` René Scharfe
2022-10-09 5:19 ` Junio C Hamano
2022-10-07 21:30 ` Junio C Hamano
2022-10-10 15:39 ` [PATCH v2] config.mak.dev: disable suggest braces error on old clang versions Jeff Hostetler via GitGitGadget
2022-10-10 18:13 ` Junio C Hamano
2022-10-11 0:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5009a325f234eef7e80335e458fbe11a2ccf5f4.1665085395.git.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=jeffhost@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).