From: Bagas Sanjaya <bagasdotme@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Carlo Arenas" <carenas@gmail.com>,
"Đoàn Trần Công Danh" <congdanhqx@gmail.com>,
felipe.contreras@gmail.com,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Jeff Hostetler" <git@jeffhostetler.com>
Subject: Re: [PATCH v3] make: add INSTALL_STRIP option variable
Date: Thu, 16 Sep 2021 17:36:17 +0700 [thread overview]
Message-ID: <e5e9848b-4378-8478-6ade-8e5f97295181@gmail.com> (raw)
In-Reply-To: <87a6kchlqc.fsf@evledraar.gmail.com>
On 16/09/21 16.50, Ævar Arnfjörð Bjarmason wrote:
> ...this really is not an INSTALL_STRIP but (using some combination of
> your own naming) a "INSTALL_XPROGRAMS_OPTS" or "INSTALL_XOPTS". I.e. you
> can supply arbitrary options to "install" with this, but only for
> binaries.
>
I think it should have been "INSTALL_STRIP_OPTS". This could haven't
been issue if we add global (applicable tobinaries and scripts)
"INSTALL_OPTS".
> Also doesn't this misbehave under MSVC when combined with *.pdb files?
> See dce7d295514 (msvc: support building Git using MS Visual C++,
> 2019-06-25) and a8b5355d808 (msvc: copy the correct `.pdb` files in the
> Makefile target `install`, 2020-09-21) , i.e. the code at the start of
> your diff context.
>
> Does stripping the main binary while having a *.pdb file error or MSCV,
> or make the *.pdb file useless, or is *.pdb an unconditional equivalent
> of INSTALL_STRIP=-s on MSCV that we should disable if this
> hopefully-then-boolean INSTALL_STRIP option is enabled?
>
I'm not familiar with MSVC, so I can't tell further except you can pass
null ("") to INSTALL_STRIP.
--
An old man doll... just what I always wanted! - Clara
next prev parent reply other threads:[~2021-09-16 10:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 12:11 [PATCH v3] make: add INSTALL_STRIP option variable Bagas Sanjaya
2021-09-16 9:50 ` Ævar Arnfjörð Bjarmason
2021-09-16 10:36 ` Bagas Sanjaya [this message]
2021-09-18 7:46 ` Ævar Arnfjörð Bjarmason
2021-09-16 19:23 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5e9848b-4378-8478-6ade-8e5f97295181@gmail.com \
--to=bagasdotme@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=carenas@gmail.com \
--cc=congdanhqx@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).