From: Johannes Sixt <j6t@kdbg.org>
To: Ash Holland <ash@sorrel.sh>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Boxuan Li <liboxuan@connect.hku.hk>,
Alban Gruin <alban.gruin@gmail.com>
Subject: Re: [PATCH v2] userdiff: support Markdown
Date: Fri, 1 May 2020 16:26:20 +0200 [thread overview]
Message-ID: <ec6239c6-b619-e11d-9166-d968bf5601db@kdbg.org> (raw)
In-Reply-To: <C2FDC85CN8B8.8IVFPUOV0BHA@what>
Am 01.05.20 um 13:49 schrieb Ash Holland:
> On Thu Apr 30, 2020 at 11:31 AM BST, Junio C Hamano wrote:
>> Taking all that together, my suspicion is
>>
>> "^ {0,3}#{1,6}[ \t]"
>>
>> i.e. "possibly slightly indented run of 6 hashes, with a whitespace
>> to catch the headers with real contents and nothing else" might be
>> more practically useful. I dunno.
>
> Sure, that looks plausible. I don't have a strong opinion on whether
> it's more useful to be consistent (and show the last heading, even if it
> doesn't contain any text) or to try as hard as possible to just show
> "some text", even if it's not the last heading, but two people have now
> suggested changing it, so I'll submit a v3 with your suggested pattern.
The pattern above captures only the hashmarks, but not the text of the
header. I suggest to append ".*".
-- Hannes
next prev parent reply other threads:[~2020-05-01 14:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 1:00 [PATCH] userdiff: support Markdown Ash Holland
2020-04-21 2:22 ` Emma Brooks
2020-04-23 23:32 ` Ash Holland
2020-04-28 21:57 ` Junio C Hamano
2020-04-29 12:12 ` Ash Holland
2020-04-23 18:17 ` Johannes Sixt
2020-04-23 23:42 ` Ash Holland
2020-04-24 17:21 ` Johannes Sixt
2020-04-29 12:21 ` Ash Holland
2020-04-29 23:05 ` [PATCH v2] " Ash Holland
2020-04-30 17:31 ` Junio C Hamano
2020-05-01 11:49 ` Ash Holland
2020-05-01 14:26 ` Johannes Sixt [this message]
2020-05-02 13:15 ` [PATCH v3] " Ash Holland
2020-05-02 13:58 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec6239c6-b619-e11d-9166-d968bf5601db@kdbg.org \
--to=j6t@kdbg.org \
--cc=alban.gruin@gmail.com \
--cc=ash@sorrel.sh \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=liboxuan@connect.hku.hk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).