From: Bagas Sanjaya <bagasdotme@gmail.com>
To: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] t: use user-specific utf-8 locale for testing
Date: Fri, 4 Jun 2021 10:32:04 +0700 [thread overview]
Message-ID: <f8cbd947-3176-34bc-a0f0-dd816298e2c7@gmail.com> (raw)
In-Reply-To: <20210602114646.17463-1-congdanhqx@gmail.com>
Hi Đoàn,
On 02/06/21 18.46, Đoàn Trần Công Danh wrote:
> In some test-cases, utf-8 locale is required. To find such locale,
> we're using the first available UTF-8 locale that returned by
> "locale -a".
>
On most systems, the first available such locale is C.UTF-8, so why
don't we just use it?
> Despite being required by POSIX, locale(1) is unavailable in some
> systems, e.g. Linux with musl libc. Some of those systems support
> utf-8 locale out of the box.
>
> However, without "locale -a", we can't guess provided UTF-8 locale.
>
> Let's give users of those systems an option to have better test
> coverage.
>
So can we assume to UTF-8 locale as default for testing on systems
without locale(1)?
> Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com>
> ---
> Makefile | 6 ++++++
> t/lib-git-svn.sh | 15 +++++++++------
> t/t9100-git-svn-basic.sh | 14 +++-----------
> t/t9115-git-svn-dcommit-funky-renames.sh | 6 +++---
> t/t9129-git-svn-i18n-commitencoding.sh | 4 ++--
> 5 files changed, 23 insertions(+), 22 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index c3565fc0f8..4b2c24e5ea 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -398,6 +398,9 @@ all::
> # with a different indexfile format version. If it isn't set the index
> # file format used is index-v[23].
> #
> +# Define GIT_TEST_UTF8_LOCALE to prefered utf-8 locale for testing.
> +# If it isn't set, use the first utf-8 locale returned by "locale -a".
> +#
Better say "... to prefer utf-8 locale for testing".
--
An old man doll... just what I always wanted! - Clara
next prev parent reply other threads:[~2021-06-04 3:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 11:46 [PATCH] t: use user-specific utf-8 locale for testing Đoàn Trần Công Danh
2021-06-02 19:56 ` Taylor Blau
2021-06-08 10:49 ` Ævar Arnfjörð Bjarmason
2021-06-03 19:27 ` Jeff King
2021-06-04 3:32 ` Bagas Sanjaya [this message]
2021-06-04 5:20 ` Đoàn Trần Công Danh
2021-06-06 16:33 ` [PATCH v2] " Đoàn Trần Công Danh
2021-06-06 20:06 ` Torsten Bögershausen
2021-06-07 0:20 ` Junio C Hamano
2021-06-07 0:48 ` [PATCH v3] t: use pre-defined utf-8 locale for testing svn Đoàn Trần Công Danh
2021-06-07 1:01 ` Junio C Hamano
2021-06-07 14:38 ` Torsten Bögershausen
2021-06-07 15:42 ` Đoàn Trần Công Danh
2021-06-08 6:35 ` Jeff King
2021-06-08 6:45 ` Đoàn Trần Công Danh
2021-06-07 1:08 ` [PATCH v4] t: use user-specified " Đoàn Trần Công Danh
2021-06-08 6:38 ` Jeff King
2021-06-08 6:56 ` [PATCH v5] " Đoàn Trần Công Danh
2021-06-08 7:26 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8cbd947-3176-34bc-a0f0-dd816298e2c7@gmail.com \
--to=bagasdotme@gmail.com \
--cc=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).