From: Glen Choo <chooglen@google.com>
To: git@vger.kernel.org
Cc: "Taylor Blau" <me@ttaylorr.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Elijah Newren" <newren@gmail.com>
Subject: How do we review changes made with coccinelle?
Date: Thu, 30 Mar 2023 11:23:40 -0700 [thread overview]
Message-ID: <kl6l7cuycd3n.fsf@chooglen-macbookpro.roam.corp.google.com> (raw)
Ævar recently sent a series that made pretty extensive use of coccinelle
to remove a lot of the_repository [1], but then we ended up in this
weird spot where even though several reviewers thought the code changes
looked good, we weren't sure about giving Reviewed-By because we didn't
know coccinelle or how to review it.
I'm pretty sure that the series could have been merged without a hitch
if reviewers knew what to do about coccinelle. I expect more of these to
appear as a result of the libification work, so it's probably a good
time for us to figure out some norms about coccinelle :)
Perhaps we could start the discussion by sharing thoughts on the
following questions, which I'll summarize in a change to
contrib/coccinelle/README (where we can do final bikeshedding):
- Is it okay to give Reviewed-By on the basis of _just_ the in-tree
changes and ignore the .cocci patch?
- If not, what should reviewers look for in .cocci? Do we have a
style?
- When do we introduce .pending.cocci vs .cocci?
- What do we do with .cocci after they've been applied?
- Do we care about new patches slowing down coccicheck?
Relevant threads
- How to learn cocci: https://lore.kernel.org/git/230326.86edpcw0yh.gmgdl@evledraar.gmail.com/
- https://lore.kernel.org/git/230328.86a5zxw31u.gmgdl@evledraar.gmail.com/
- https://lore.kernel.org/git/230326.86ileow1fu.gmgdl@evledraar.gmail.com/
[1] https://lore.kernel.org/git/cover-v2-00.17-00000000000-20230328T110946Z-avarab@gmail.com/
next reply other threads:[~2023-03-30 18:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 18:23 Glen Choo [this message]
2023-03-30 19:13 ` How do we review changes made with coccinelle? Junio C Hamano
2023-03-31 17:17 ` Glen Choo
2023-03-31 18:17 ` Junio C Hamano
2023-03-31 23:49 ` Taylor Blau
2023-03-31 23:53 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=kl6l7cuycd3n.fsf@chooglen-macbookpro.roam.corp.google.com \
--to=chooglen@google.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).