git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Glen Choo <chooglen@google.com>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: ar/submodule-udpate (was Re: What's cooking in git.git (Mar 2022, #02; Mon, 7))
Date: Wed, 09 Mar 2022 10:03:42 -0800	[thread overview]
Message-ID: <kl6l8rtj57gh.fsf@chooglen-macbookpro.roam.corp.google.com> (raw)
In-Reply-To: <xmqqilspp5yg.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> * ar/submodule-update (2022-03-04) 13 commits
>  - submodule--helper update-clone: check for --filter and --init
>  - submodule update: add tests for --filter
>  - submodule--helper: remove ensure-core-worktree
>  - submodule--helper update-clone: learn --init
>  - submodule--helper: allow setting superprefix for init_submodule()
>  - submodule--helper: refactor get_submodule_displaypath()
>  - submodule--helper run-update-procedure: learn --remote
>  - submodule--helper: don't use bitfield indirection for parse_options()
>  - submodule--helper: get remote names from any repository
>  - submodule--helper run-update-procedure: remove --suboid
>  - submodule--helper: reorganize code for sh to C conversion
>  - submodule--helper: remove update-module-mode
>  - submodule tests: test for init and update failure output
>
>  Rewrite of "git submodule update" in C (early part).
>
>  Will merge to 'next'?
>  source: <20220305001401.20888-1-chooglen@google.com>

I don't anticipate further comments, so I think this set of patches
should be pretty safe to merge :)

A comment on the branch name: we kept the name 'ar/submodule-update'
from when Atharva Raykar <raykar.ath@gmail.com> prepared v1 of his
series that converts all of "git submodule update" to C. When other
authors sent subsequent versions, it still made sense to keep this name
because the patches still reached the same end state of having all of
"git submodule update" in C.

However, I've since broken this series up in two (to play better with
other topics), and the above-named patches don't do a _full_ conversion
of "git submodule update". Is something like "ar/submodule-update-1"
more appropriate?

  parent reply	other threads:[~2022-03-09 18:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-08  1:51 What's cooking in git.git (Mar 2022, #02; Mon, 7) Junio C Hamano
2022-03-08  8:05 ` Teng Long
2022-03-09 19:14   ` Junio C Hamano
2022-03-08 16:08 ` ds/partial-bundles (was Re: What's cooking in git.git (Mar 2022, #02; Mon, 7)) Derrick Stolee
2022-03-09 16:12 ` jc/stash-drop " Phillip Wood
2022-03-09 17:10   ` Junio C Hamano
2022-03-09 18:03 ` Glen Choo [this message]
2022-03-09 19:27   ` ar/submodule-udpate " Junio C Hamano
2022-03-09 22:09     ` Glen Choo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=kl6l8rtj57gh.fsf@chooglen-macbookpro.roam.corp.google.com \
    --to=chooglen@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).