From: Sean Allred <allred.sean@gmail.com>
To: Sean Allred <allred.sean@gmail.com>
Cc: Tao Klerks <tao@klerks.biz>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
Sean Allred <sallred@epic.com>,
Kyle VandeWalle <kvandewa@epic.com>, git <git@vger.kernel.org>
Subject: Re: [BUGREPORT] Why is git-push fetching content?
Date: Sat, 08 Jul 2023 03:39:19 -0500 [thread overview]
Message-ID: <m0pm52eqg5.fsf@epic96565.epic.com> (raw)
In-Reply-To: <m0zg46eueb.fsf@epic96565.epic.com>
Following up with the results of my bisect (more discussion below). I'm
forced to conclude this may somehow have never worked as I'm expecting
(even though I do recall it working well in a long-gone environment),
but I'm very much hoping I just did the bisect incorrectly. (It's not a
feature I need to use much.)
So, is this a bug or is this working as intended for a good reason?
Sean Allred <allred.sean@gmail.com> writes:
> Thanks for the replies. I'd like to bump this up again. This has come up
> in a new context and I don't see a viable workaround for us that doesn't
> involve a rewrite of the process and an excessive amount of new
> infrastructure.
>
> I have a feeling this is somehow a general issue with promisor remotes,
> though I don't know enough about how they work to know where to start
> investigation. I've got what I believe to be minimal reproduction steps
> below.
>
> [...]
>
> I believe the following can be used with git-bisect to determine if this
> truly ever worked or is a regression:
>
> setup:
> #!/bin/bash
>
> repo="https://github.com/vermiculus/testibus.git"
> repo_dir="~/path/to/repo"
>
> git clone --no-checkout --depth=1 --no-tags --filter=tree:0 "$repo" "$repo_dir"
> git -C "$repo_dir" remote set-url origin unreachable
>
> bisect script:
> git -C "$repo_dir" rev-list --objects --all
>
> (obviously using the just-built git)
>
> I'm going to start running this bisect, but I suspect it will take a
> while, so I wanted to get this out there.
I ended up using a bisect script that looks like this
#!/bin/bash
make clean
NO_GETTEXT=1 make -j8 || exit 125
./bin-wrappers/git -C "$1" rev-list --objects --all || exit 1
git rev-parse HEAD >> ../good-commits
and running
git bisect start main 637fc4467e57872008171958eda0428818a7ee03
git bisect run ../bisect-script.sh ~/tmp/testibus/
It took less time than I thought, but unfortunately I was never able to
actually find a 'good' commit. I arbitrarily chose "partial-clone:
design doc" (Jeff Hostetler, Dec 14 2017) as the first commit to the
partial-clone design document (under the assumption that it worked at
some point). If potentially lying to git-bisect in this way is
especially liable to bust it, I can start the exponentially-more-
expensive process of testing every commit along --first-parent, but I
suspect this may have never worked as I'm expecting.
--
Sean Allred
next prev parent reply other threads:[~2023-07-08 8:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 22:01 [BUGREPORT] Why is git-push fetching content? Sean Allred
2023-02-21 23:02 ` brian m. carlson
2023-02-22 15:04 ` Sean Allred
2023-06-20 11:26 ` Tao Klerks
2023-07-08 6:27 ` Sean Allred
2023-07-08 8:39 ` Sean Allred [this message]
[not found] ` <7bfb7ecd4a4c78668f97b00d5f06af0c9b2878269476e89c3311eeb8071b1ab3@mu.id>
2023-02-22 15:48 ` Sean Allred
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m0pm52eqg5.fsf@epic96565.epic.com \
--to=allred.sean@gmail.com \
--cc=git@vger.kernel.org \
--cc=kvandewa@epic.com \
--cc=sallred@epic.com \
--cc=sandals@crustytoothpaste.net \
--cc=tao@klerks.biz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).