From: Joey Salazar <jgsal@protonmail.com>
To: Denton Liu <liu.denton@gmail.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [OUTREACHY][PATCH v1] doc: fix naming of response-end-pkt
Date: Wed, 17 Feb 2021 23:59:47 +0000 [thread overview]
Message-ID: <mFXIveS58B7aSefQQEpY87ZyWBBrDhKPgOyEdriyZiD3Dn61_bhvLaJbjzGFRnX0rX7Zjvvxqobf684akMJYjd6qpFBVVMjwtKoFA2hSO_k=@protonmail.com> (raw)
In-Reply-To: <YCz4+xPVyL+hTZzR@generichostname>
Hi Denton,
On Wednesday, February 17, 2021 5:07 AM, Denton Liu wrote:
> Hi Joey,
>
> A couple of aesthetic details: I see that these changes are based on MR
> !1922 so if you decide to take these suggestions, you'll probably need
> to apply them there too.
>
> 1. It'd probably read better as "Response End Packet" (with the
> "e" capitalised)
>
> 2. The mix of underscore and hyphen in response_end-pkt is a
> little odd, although I see that you've done it to make it
> match the surrounding code[3].
Well noted, I'll follow up shortly with PATCH v2 to incorporate both changes.
Thank you,
Joey
prev parent reply other threads:[~2021-02-18 0:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 21:21 [OUTREACHY][PATCH v1] doc: fix naming of response-end-pkt Joey Salazar
2021-02-16 23:03 ` Junio C Hamano
2021-02-17 11:07 ` Denton Liu
2021-02-17 23:59 ` Joey Salazar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='mFXIveS58B7aSefQQEpY87ZyWBBrDhKPgOyEdriyZiD3Dn61_bhvLaJbjzGFRnX0rX7Zjvvxqobf684akMJYjd6qpFBVVMjwtKoFA2hSO_k=@protonmail.com' \
--to=jgsal@protonmail.com \
--cc=git@vger.kernel.org \
--cc=liu.denton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).