From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Elijah Newren <newren@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com, predatoramigo@gmail.com,
phillip.wood@talktalk.net
Subject: Re: [PATCH v4 0/8] Reimplement rebase --merge via interactive machinery
Date: Mon, 21 Jan 2019 22:01:13 +0100 (STD) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1901212200400.41@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.1901211702380.41@tvgsbejvaqbjf.bet>
Hi Elijah,
On Mon, 21 Jan 2019, Johannes Schindelin wrote:
> On Tue, 11 Dec 2018, Elijah Newren wrote:
>
> > Differences since v3 (full range-diff below):
> > - Fixed the redundant "fatal: error:" error message prefixes, as pointed
> > out by Duy
> > - Rebased on 2.20.0
>
> - Fixed the "comptable" tyop
>
> This, and the range-diff, look reasonable to me.
And now that I looked through all 8 patches, those look reasonable to me,
too. I think this is ready for `next`.
Ciao,
Dscho
>
> Thanks,
> Dscho
>
> > Elijah Newren (8):
> > rebase: make builtin and legacy script error messages the same
> > rebase: fix incompatible options error message
> > t5407: add a test demonstrating how interactive handles --skip
> > differently
> > am, rebase--merge: do not overlook --skip'ed commits with post-rewrite
> > git-rebase, sequencer: extend --quiet option for the interactive
> > machinery
> > git-legacy-rebase: simplify unnecessary triply-nested if
> > rebase: define linearization ordering and enforce it
> > rebase: Implement --merge via the interactive machinery
> >
> > .gitignore | 1 -
> > Documentation/git-rebase.txt | 17 +---
> > Makefile | 1 -
> > builtin/am.c | 9 ++
> > builtin/rebase.c | 30 ++----
> > git-legacy-rebase.sh | 65 ++++++------
> > git-rebase--am.sh | 2 +-
> > git-rebase--common.sh | 2 +-
> > git-rebase--merge.sh | 164 ------------------------------
> > sequencer.c | 23 +++--
> > sequencer.h | 1 +
> > t/t3406-rebase-message.sh | 7 +-
> > t/t3420-rebase-autostash.sh | 78 ++------------
> > t/t3421-rebase-topology-linear.sh | 10 +-
> > t/t3425-rebase-topology-merges.sh | 15 ++-
> > t/t5407-post-rewrite-hook.sh | 34 +++++++
> > t/t9903-bash-prompt.sh | 2 +-
> > 17 files changed, 121 insertions(+), 340 deletions(-)
> > delete mode 100644 git-rebase--merge.sh
> >
> > Range-diff:
> > -: ---------- > 1: 2e8b1bcb8b rebase: make builtin and legacy script error messages the same
> > 1: 2f4bdd1980 ! 2: eba87828c6 rebase: fix incompatible options error message
> > @@ -9,12 +9,12 @@
> > understood by separate backends were used:
> >
> > $ git rebase --keep --ignore-whitespace
> > - fatal: error: cannot combine interactive options (--interactive, --exec,
> > + fatal: cannot combine interactive options (--interactive, --exec,
> > --rebase-merges, --preserve-merges, --keep-empty, --root + --onto) with
> > am options (.git/rebase-apply/applying)
> >
> > $ git rebase --merge --ignore-whitespace
> > - fatal: error: cannot combine merge options (--merge, --strategy,
> > + fatal: cannot combine merge options (--merge, --strategy,
> > --strategy-option) with am options (.git/rebase-apply/applying)
> >
> > Note that in both cases, the list of "am options" is
> > @@ -33,18 +33,17 @@
> > break;
> >
> > if (is_interactive(&options) && i >= 0)
> > -- die(_("error: cannot combine interactive options "
> > +- die(_("cannot combine interactive options "
> > - "(--interactive, --exec, --rebase-merges, "
> > - "--preserve-merges, --keep-empty, --root + "
> > - "--onto) with am options (%s)"), buf.buf);
> > -+ die(_("error: cannot combine am options "
> > ++ die(_("cannot combine am options "
> > + "with interactive options"));
> > if (options.type == REBASE_MERGE && i >= 0)
> > -- die(_("error: cannot combine merge options (--merge, "
> > +- die(_("cannot combine merge options (--merge, "
> > - "--strategy, --strategy-option) with am options "
> > - "(%s)"), buf.buf);
> > -+ die(_("error: cannot combine am options "
> > -+ "with merge options "));
> > ++ die(_("cannot combine am options with merge options "));
> > }
> >
> > if (options.signoff) {
> > @@ -56,15 +55,15 @@
> > then
> > if test -n "$incompatible_opts"
> > then
> > -- die "$(gettext "error: cannot combine interactive options (--interactive, --exec, --rebase-merges, --preserve-merges, --keep-empty, --root + --onto) with am options ($incompatible_opts)")"
> > -+ die "$(gettext "error: cannot combine am options with interactive options")"
> > +- die "$(gettext "fatal: cannot combine interactive options (--interactive, --exec, --rebase-merges, --preserve-merges, --keep-empty, --root + --onto) with am options ($incompatible_opts)")"
> > ++ die "$(gettext "fatal: cannot combine am options with interactive options")"
> > fi
> > fi
> > if test -n "$do_merge"; then
> > if test -n "$incompatible_opts"
> > then
> > -- die "$(gettext "error: cannot combine merge options (--merge, --strategy, --strategy-option) with am options ($incompatible_opts)")"
> > -+ die "$(gettext "error: cannot combine am options with merge options")"
> > +- die "$(gettext "fatal: cannot combine merge options (--merge, --strategy, --strategy-option) with am options ($incompatible_opts)")"
> > ++ die "$(gettext "fatal: cannot combine am options with merge options")"
> > fi
> > fi
> > fi
> > 2: cc33a8ccc1 = 3: 15d929edb2 t5407: add a test demonstrating how interactive handles --skip differently
> > 3: f5838ef763 = 4: c9d6d5141e am, rebase--merge: do not overlook --skip'ed commits with post-rewrite
> > 4: 50dc863d9f = 5: 0b19ad8e2d git-rebase, sequencer: extend --quiet option for the interactive machinery
> > 5: 35cf552f27 ! 6: 5ded8654ec git-legacy-rebase: simplify unnecessary triply-nested if
> > @@ -18,7 +18,7 @@
> > moving the innermost conditional to the outside, allowing us to remove
> > the test on git_am_opt entirely and giving us the following form:
> >
> > - if incomptable_opts:
> > + if incompatible_opts:
> > if interactive:
> > show_error_about_interactive_and_am_incompatibilities
> > if rebase-merge:
> > @@ -44,18 +44,18 @@
> > then
> > - if test -n "$incompatible_opts"
> > - then
> > -- die "$(gettext "error: cannot combine am options with interactive options")"
> > +- die "$(gettext "fatal: cannot combine am options with interactive options")"
> > - fi
> > -+ die "$(gettext "error: cannot combine am options with interactive options")"
> > ++ die "$(gettext "fatal: cannot combine am options with interactive options")"
> > fi
> > - if test -n "$do_merge"; then
> > - if test -n "$incompatible_opts"
> > - then
> > -- die "$(gettext "error: cannot combine am options with merge options")"
> > +- die "$(gettext "fatal: cannot combine am options with merge options")"
> > - fi
> > + if test -n "$do_merge"
> > + then
> > -+ die "$(gettext "error: cannot combine am options with merge options")"
> > ++ die "$(gettext "fatal: cannot combine am options with merge options")"
> > fi
> > fi
> >
> > 6: 2a3d8ff1c1 = 7: bb8e5a4527 rebase: define linearization ordering and enforce it
> > 7: 58371d377a ! 8: 5de428d695 rebase: Implement --merge via the interactive machinery
> > @@ -142,14 +142,15 @@
> > imply_interactive(&options, "--root without --onto");
> >
> > @@
> > + break;
> >
> > if (is_interactive(&options) && i >= 0)
> > - die(_("error: cannot combine am options "
> > +- die(_("cannot combine am options "
> > - "with interactive options"));
> > - if (options.type == REBASE_MERGE && i >= 0)
> > -- die(_("error: cannot combine am options "
> > -- "with merge options "));
> > -+ "with either interactive or merge options"));
> > +- die(_("cannot combine am options with merge options "));
> > ++ die(_("cannot combine am options with either "
> > ++ "interactive or merge options"));
> > }
> >
> > if (options.signoff) {
> > @@ -205,13 +206,13 @@
> > then
> > - if test -n "$interactive_rebase"
> > - then
> > -- die "$(gettext "error: cannot combine am options with interactive options")"
> > +- die "$(gettext "fatal: cannot combine am options with interactive options")"
> > - fi
> > - if test -n "$do_merge"
> > + if test -n "$actually_interactive" || test "$do_merge"
> > then
> > -- die "$(gettext "error: cannot combine am options with merge options")"
> > -+ die "$(gettext "error: cannot combine am options with either interactive or merge options")"
> > +- die "$(gettext "fatal: cannot combine am options with merge options")"
> > ++ die "$(gettext "fatal: cannot combine am options with either interactive or merge options")"
> > fi
> > fi
> >
> > @@ -225,7 +226,7 @@
> > # linear history?
> > ! (git rev-list --parents "$onto".."$orig_head" | sane_grep " .* ") > /dev/null
> > @@
> > - GIT_PAGER='' git diff --stat --summary "$mb" "$onto"
> > + GIT_PAGER='' git diff --stat --summary "$mb_tree" "$onto"
> > fi
> >
> > +if test -z "$actually_interactive" && test "$mb" = "$orig_head"
> > --
> > 2.20.0.8.g5de428d695
> >
> >
>
next prev parent reply other threads:[~2019-01-21 21:01 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 6:01 [PATCH v2 0/2] Reimplement rebase --merge via interactive machinery Elijah Newren
2018-11-08 6:01 ` [PATCH v2 1/2] git-rebase, sequencer: extend --quiet option for the " Elijah Newren
2018-11-12 15:11 ` Johannes Schindelin
2018-11-08 6:01 ` [PATCH v2 2/2] rebase: Implement --merge via git-rebase--interactive Elijah Newren
2018-11-12 16:21 ` Johannes Schindelin
2018-11-12 18:21 ` Phillip Wood
2018-11-13 9:18 ` Johannes Schindelin
2018-11-14 23:06 ` Elijah Newren
2018-11-13 16:06 ` Elijah Newren
2018-11-14 23:03 ` Elijah Newren
2018-11-15 12:27 ` Johannes Schindelin
2018-11-08 6:33 ` [PATCH v2 0/2] Reimplement rebase --merge via interactive machinery Elijah Newren
2018-11-22 4:48 ` [PATCH v3 0/7] " Elijah Newren
2018-11-22 4:48 ` [PATCH v3 1/7] rebase: fix incompatible options error message Elijah Newren
2018-11-28 8:28 ` Johannes Schindelin
2018-11-28 15:58 ` Elijah Newren
2018-11-28 16:12 ` Duy Nguyen
2018-11-28 16:31 ` Elijah Newren
2018-11-22 4:48 ` [PATCH v3 2/7] t5407: add a test demonstrating how interactive handles --skip differently Elijah Newren
2018-11-22 4:48 ` [PATCH v3 3/7] am, rebase--merge: do not overlook --skip'ed commits with post-rewrite Elijah Newren
2018-11-22 4:48 ` [PATCH v3 4/7] git-rebase, sequencer: extend --quiet option for the interactive machinery Elijah Newren
2018-11-22 4:48 ` [PATCH v3 5/7] git-legacy-rebase: simplify unnecessary triply-nested if Elijah Newren
2018-11-22 4:48 ` [PATCH v3 6/7] rebase: define linearization ordering and enforce it Elijah Newren
2018-11-22 4:48 ` [PATCH v3 7/7] rebase: Implement --merge via the interactive machinery Elijah Newren
2018-12-11 16:11 ` [PATCH v4 0/8] Reimplement rebase --merge via " Elijah Newren
2018-12-11 16:11 ` [PATCH v4 1/8] rebase: make builtin and legacy script error messages the same Elijah Newren
2018-12-11 16:11 ` [PATCH v4 2/8] rebase: fix incompatible options error message Elijah Newren
2018-12-11 16:11 ` [PATCH v4 3/8] t5407: add a test demonstrating how interactive handles --skip differently Elijah Newren
2018-12-11 16:11 ` [PATCH v4 4/8] am, rebase--merge: do not overlook --skip'ed commits with post-rewrite Elijah Newren
2019-01-21 16:07 ` Johannes Schindelin
2019-01-21 17:59 ` Elijah Newren
2019-01-21 18:11 ` Johannes Schindelin
2018-12-11 16:11 ` [PATCH v4 5/8] git-rebase, sequencer: extend --quiet option for the interactive machinery Elijah Newren
2019-01-21 16:10 ` Johannes Schindelin
2019-01-21 17:50 ` Elijah Newren
2019-01-21 18:19 ` Johannes Schindelin
2019-01-21 18:22 ` Johannes Schindelin
2019-01-22 20:39 ` Junio C Hamano
2019-02-20 11:00 ` Phillip Wood
2019-02-21 17:44 ` Elijah Newren
2018-12-11 16:11 ` [PATCH v4 6/8] git-legacy-rebase: simplify unnecessary triply-nested if Elijah Newren
2018-12-11 16:11 ` [PATCH v4 7/8] rebase: define linearization ordering and enforce it Elijah Newren
2018-12-11 16:11 ` [PATCH v4 8/8] rebase: Implement --merge via the interactive machinery Elijah Newren
2019-01-07 17:15 ` [PATCH v4 0/8] Reimplement rebase --merge via " Elijah Newren
2019-01-07 19:46 ` Junio C Hamano
2019-01-07 20:11 ` Junio C Hamano
2019-01-07 20:39 ` Elijah Newren
2019-01-11 18:36 ` Elijah Newren
2019-01-18 13:36 ` Johannes Schindelin
2019-01-18 14:22 ` Johannes Schindelin
2019-01-18 17:55 ` Junio C Hamano
2019-01-18 18:07 ` Elijah Newren
2019-01-18 21:03 ` Johannes Schindelin
2019-01-18 21:21 ` Junio C Hamano
2019-01-21 21:02 ` Johannes Schindelin
2019-01-21 16:03 ` Johannes Schindelin
2019-01-21 21:01 ` Johannes Schindelin [this message]
2019-01-21 21:04 ` Elijah Newren
2019-01-29 1:39 ` [PATCH v5 " Elijah Newren
2019-01-29 1:39 ` [PATCH v5 1/8] rebase: make builtin and legacy script error messages the same Elijah Newren
2019-01-29 1:39 ` [PATCH v5 2/8] rebase: fix incompatible options error message Elijah Newren
2019-01-29 1:39 ` [PATCH v5 3/8] t5407: add a test demonstrating how interactive handles --skip differently Elijah Newren
2019-01-29 1:39 ` [PATCH v5 4/8] am, rebase--merge: do not overlook --skip'ed commits with post-rewrite Elijah Newren
2019-01-29 1:39 ` [PATCH v5 5/8] git-rebase, sequencer: extend --quiet option for the interactive machinery Elijah Newren
2019-01-29 1:39 ` [PATCH v5 6/8] git-legacy-rebase: simplify unnecessary triply-nested if Elijah Newren
2019-01-29 1:39 ` [PATCH v5 7/8] rebase: define linearization ordering and enforce it Elijah Newren
2019-01-29 1:39 ` [PATCH v5 8/8] rebase: implement --merge via the interactive machinery Elijah Newren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1901212200400.41@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
--cc=phillip.wood@talktalk.net \
--cc=predatoramigo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).