From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Emily Shaffer <emilyshaffer@google.com>, git@vger.kernel.org
Subject: Re: [PATCH 3/3] myfirstcontrib: hint to find gitgitgadget allower
Date: Tue, 29 Oct 2019 21:43:16 +0100 (CET) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1910292141340.46@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <20191026011459.GC39574@google.com>
Hi Jonathan,
On Fri, 25 Oct 2019, Jonathan Nieder wrote:
> Emily Shaffer wrote:
>
> > GitGitGadget, a handy tool for converting pull requests against Git into
> > Git-mailing-list-friendly-patch-emails, requires as anti-spam that all
> > new users be "/allow"ed by an existing user once before it will do
> > anything for that new user. While this tutorial explained that
> > mechanism, it did not give much hint on how to go about finding someone
> > to allow your new pull request. So, teach our new GitGitGadget user
> > where to look for someone who can add their name to the list.
> >
> > The advice in this patch is based on the advice proposed for
> > GitGitGadget: https://github.com/gitgitgadget/gitgitgadget/pull/138
> >
> > Signed-off-by: Emily Shaffer <emilyshaffer@google.com>
> > ---
> > Documentation/MyFirstContribution.txt | 8 ++++++++
> > 1 file changed, 8 insertions(+)
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>
> Though I'd appreciate an ack from a gitgitgadget specialist too, so
> cc-ing Dscho.
Seeing as the suggestions from gitgitgadget/gitgitgadget#138 partially
came from me (and that I merged that PR after reviewing it), this comes
very easily:
Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Thanks,
Dscho
>
> > diff --git a/Documentation/MyFirstContribution.txt b/Documentation/MyFirstContribution.txt
> > index b8ffeda07e..2de06de026 100644
> > --- a/Documentation/MyFirstContribution.txt
> > +++ b/Documentation/MyFirstContribution.txt
> > @@ -789,6 +789,14 @@ will automatically run your PRs through the CI even without the permission given
> > but you will not be able to `/submit` your changes until someone allows you to
> > use the tool.
> >
> > +NOTE: You can typically find someone who can `/allow` you on GitGitGadget by
> > +either examining recent pull requests where someone has been granted `/allow`
> > +(https://github.com/gitgitgadget/git/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aopen+%22%2Fallow%22[Search:
> > +is:pr is:open "/allow"]), in which case both the author and the person who
> > +granted the `/allow` can now `/allow` you, or by inquiring on the
> > +https://webchat.freenode.net/#git-devel[#git-devel] IRC channel on Freenode
> > +linking your pull request and asking for someone to `/allow` you.
> > +
> > If the CI fails, you can update your changes with `git rebase -i` and push your
> > branch again:
> >
>
next prev parent reply other threads:[~2019-10-29 20:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-26 0:51 [PATCH 0/3] some clarifications to MyFirstContribution Emily Shaffer
2019-10-26 0:51 ` [PATCH 1/3] myfirstcontrib: add 'psuh' to command-list.txt Emily Shaffer
2019-10-26 1:08 ` Jonathan Nieder
2019-10-26 8:00 ` SZEDER Gábor
2019-10-28 1:24 ` Junio C Hamano
2019-10-28 11:25 ` SZEDER Gábor
2019-10-29 20:39 ` Johannes Schindelin
2019-10-26 0:51 ` [PATCH 2/3] myfirstcontrib: add dependency installation step Emily Shaffer
2019-10-26 1:12 ` Jonathan Nieder
2019-10-28 1:27 ` Junio C Hamano
2019-10-31 20:58 ` Emily Shaffer
2019-10-26 0:51 ` [PATCH 3/3] myfirstcontrib: hint to find gitgitgadget allower Emily Shaffer
2019-10-26 1:15 ` Jonathan Nieder
2019-10-29 20:43 ` Johannes Schindelin [this message]
2019-10-27 1:39 ` Pratyush Yadav
2019-10-26 1:17 ` [PATCH 0/3] some clarifications to MyFirstContribution Jonathan Nieder
2019-10-31 21:03 ` [PATCH v2 " Emily Shaffer
2019-10-31 21:03 ` [PATCH v2 1/3] myfirstcontrib: add 'psuh' to command-list.txt Emily Shaffer
2019-10-31 21:03 ` [PATCH v2 2/3] myfirstcontrib: add dependency installation step Emily Shaffer
2019-10-31 21:03 ` [PATCH v2 3/3] myfirstcontrib: hint to find gitgitgadget allower Emily Shaffer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1910292141340.46@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--subject='Re: [PATCH 3/3] myfirstcontrib: hint to find gitgitgadget allower' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).