Re: [PATCH 1/3] t/lib-httpd: avoid using BSD's sed

[Johannes Schindelin <Johannes.Schindelin@gmx.de>]

Hi Ed,

On Thu, 27 Feb 2020, Ed Maste wrote:

> On Thu, 27 Feb 2020 at 10:40, Johannes Schindelin
> <Johannes.Schindelin@gmx.de> wrote:
> >
> > My bad. I looked at StackOverflow and there the claim was that all BSD
> > seds behave that way.
> >
> > Of course, SO always lags behind by a couple years (although even such old
> > threads are often very useful), so it is possible that _old_ BSD sed
> > behaved that way.
>
> Yeah, I wondered about the different behaviour, and asked on Twitter
> about it. You're right, it is historical BSD behaviour and NetBSD at
> least still appends the newline. FreeBSD changed this in 2014 -
> http://bugs.freebsd.org/160745.

Thank you for digging into this!

> > Related, I saw that Cirrus CI offers FreeBSD builds, maybe you'd be
> > interested in supporting that out of the box in
> > https://github.com/git/git?
>
> Indeed - there is a .cirrus.yml in git now which builds and runs tests
> (on FreeBSD 12.1). I'll look into working with the GitHub organization
> owners for git and gitgitgadget to see about allowing Cirrus to access
> the repositories.

Oy, I had forgotten that you worked on this. I enabled this in the git and
in the gitgitgadget orgs. The next pushes/PRs should benefit from this.

Thanks,
Dscho