git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org, Denton Liu <liu.denton@gmail.com>
Subject: Re: [PATCH v3 0/3] Accommodate for pu having been renamed to seen
Date: Mon, 29 Jun 2020 16:07:14 +0200 (CEST)	[thread overview]
Message-ID: <nycvar.QRO.7.76.6.2006291606060.56@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqq366j5d57.fsf@gitster.c.googlers.com>

[-- Attachment #1: Type: text/plain, Size: 1194 bytes --]

Hi Junio,

On Thu, 25 Jun 2020, Junio C Hamano wrote:

> "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
> writes:
>
> > This patch series adjusts Git's own source code to reflect that change.
> >
> > Please note that even with these patches, there are still a couple places
> > where pu is used:
> >
> >  * In the translations. These are legitimate words in languages that are not
> >    English (as in "gpg n'a pas pu signer les données" where "pu" is French
> >    for the English "could").
> >  * In upload-pack.c, where a variable named pu is short form for
> >    "pack-objects updates".
> >
> > Changes since v2:
> >
> >  * One accidental quoting change in v1 was reverted.
>
> Thanks for being thorough.
>
> You could have just told me that the fixup queued on 'seen' looks
> good to you and squash it in the first step instead to save one
> roundtrip, but replacing with a new set of three patches is not so
> bad, either ;-)

To be honest, the GitGitGadget-based workflow makes it quicker for me to
just submit a new iteration. In fact, I did not even see your fixup until
I read your mail.

Ciao,
Dscho

>
> Will replace.
>
>

  reply	other threads:[~2020-06-30 13:56 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-23 15:04 [PATCH 0/3] Accommodate for pu having been renamed to seen Johannes Schindelin via GitGitGadget
2020-06-23 15:04 ` [PATCH 1/3] docs: adjust for the recent rename of `pu` to `seen` Johannes Schindelin via GitGitGadget
2020-06-23 15:31   ` Đoàn Trần Công Danh
2020-06-23 19:31     ` Junio C Hamano
2020-06-23 21:32       ` Johannes Schindelin
2020-06-24  0:46       ` Đoàn Trần Công Danh
2020-06-23 15:04 ` [PATCH 2/3] docs: adjust the technical overview for the rename `pu` -> `seen` Johannes Schindelin via GitGitGadget
2020-06-23 15:04 ` [PATCH 3/3] tests: reference `seen` wherever `pu` was referenced Johannes Schindelin via GitGitGadget
2020-06-24 14:48 ` [PATCH v2 0/3] Accommodate for pu having been renamed to seen Johannes Schindelin via GitGitGadget
2020-06-24 14:48   ` [PATCH v2 1/3] docs: adjust for the recent rename of `pu` to `seen` Johannes Schindelin via GitGitGadget
2020-06-24 15:07     ` Denton Liu
2020-06-24 14:48   ` [PATCH v2 2/3] docs: adjust the technical overview for the rename `pu` -> `seen` Johannes Schindelin via GitGitGadget
2020-06-24 14:48   ` [PATCH v2 3/3] tests: reference `seen` wherever `pu` was referenced Johannes Schindelin via GitGitGadget
2020-06-24 15:24   ` [PATCH v2 0/3] Accommodate for pu having been renamed to seen Denton Liu
2020-06-24 15:42     ` Junio C Hamano
2020-06-29 13:40       ` Johannes Schindelin
2020-06-24 15:38   ` Junio C Hamano
2020-06-24 17:05     ` Junio C Hamano
2020-06-24 17:24       ` Denton Liu
2020-06-24 17:38         ` Junio C Hamano
2020-06-29 14:05       ` Johannes Schindelin
2020-06-25 12:18   ` [PATCH v3 " Johannes Schindelin via GitGitGadget
2020-06-25 12:18     ` [PATCH v3 1/3] docs: adjust for the recent rename of `pu` to `seen` Johannes Schindelin via GitGitGadget
2020-06-25 12:18     ` [PATCH v3 2/3] docs: adjust the technical overview for the rename `pu` -> `seen` Johannes Schindelin via GitGitGadget
2020-06-25 12:18     ` [PATCH v3 3/3] tests: reference `seen` wherever `pu` was referenced Johannes Schindelin via GitGitGadget
2020-06-25 16:22     ` [PATCH v3 0/3] Accommodate for pu having been renamed to seen Junio C Hamano
2020-06-29 14:07       ` Johannes Schindelin [this message]
2020-06-30 16:03         ` Junio C Hamano
2020-07-01 10:42           ` Johannes Schindelin
2020-06-26  9:06     ` Update ProGit for pu -> seen change? (was Re: [PATCH v3 0/3] Accommodate for pu having been renamed to seen) Kaartic Sivaraam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.QRO.7.76.6.2006291606060.56@tvgsbejvaqbjf.bet \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=liu.denton@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).